You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "David E. Jones (JIRA)" <ji...@apache.org> on 2006/11/25 09:51:03 UTC
[jira] Commented: (OFBIZ-495) User Preferences Feature
[ http://issues.apache.org/jira/browse/OFBIZ-495?page=comments#action_12452564 ]
David E. Jones commented on OFBIZ-495:
--------------------------------------
Just a few quick thoughts based on an initial review of this:
1. there are dozens of lines unnecessarily changed in this patch (ie formatting changes, etc that have nothing to do with functionality)
2. a few Java formatting faux pas, like if/else without curly braces
3. this should go into an existing component instead of being added to a new component; perhaps the "common" component would be a good fit, but this should probably be discussed (along with various other things)
4. why were the services written in Java and not as simple-methods? these seem to mostly be getting and organizing data into generic structures, which is what simple-methods are best for
5. this patch somehow has two copies of each file/change...
In general because this is a fair sized change this should be evaluated and feedback offered by various people. Review of this sort of thing should include review of entity model additions, security/permissions, seed and demo data (and properly split into seed and demo files), implementation approaches, general organization, examples, etc.
More generally, this looks like a great start Adrian, so I hope it picks up interest and is finished and included in OFBiz.
> User Preferences Feature
> ------------------------
>
> Key: OFBIZ-495
> URL: http://issues.apache.org/jira/browse/OFBIZ-495
> Project: OFBiz (The Open for Business Project)
> Issue Type: New Feature
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: framework.patch
>
>
> The User Preferences Services are intended to store and retrieve the current user's preferences. User preferences can be used to control UI elements, frequently used search and report criteria, and more.
> That attached patch should be applied to the framework folder of revision 475825. Build OFBiz and the framework/user folder. Run ant-install. Browse to https://127.0.0.1:8443/example/control/UserPrefDemo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira