You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by da...@apache.org on 2026/06/19 06:47:39 UTC
(causeway) 08/11: CAUSEWAY-4039: renames ReplayableCommand#isExportable to isKnownParticipants
This is an automated email from the ASF dual-hosted git repository.
danhaywood pushed a commit to branch CAUSEWAY-4039
in repository https://gitbox.apache.org/repos/asf/causeway.git
commit d78f7ff786fc55761b6e569def88a59eea140f9b
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Fri Jun 19 06:55:14 2026 +0100
CAUSEWAY-4039: renames ReplayableCommand#isExportable to isKnownParticipants
---
.../applib/dom/replay/CommandManagerExport.java | 2 +-
.../CommandManagerExport_excludeCommands.java | 2 +-
.../CommandManagerExport_exportSelected.java | 2 +-
.../ReplayableCommand.columnOrder.fallback.txt | 2 +-
.../applib/dom/replay/ReplayableCommand.java | 10 +++-------
.../CommandExportManagerSelectedTestExport.java | 22 +++++++++++-----------
.../dom/replay/ReplayableCommandMappingTest.java | 2 +-
7 files changed, 19 insertions(+), 23 deletions(-)
diff --git a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport.java b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport.java
index c46a5b56b57..af57a5c2c78 100644
--- a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport.java
+++ b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport.java
@@ -145,7 +145,7 @@ Optional<CommandExportKnownTargetValidator.Failure> validateKnownTargets(
}
@Programmatic
- Boolean isExportable(final CommandLogEntry commandLogEntry) {
+ Boolean isKnownParticipants(final CommandLogEntry commandLogEntry) {
if (commandLogEntry == null || !isRecordingSupportEnabled()) {
return null;
}
diff --git a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport_excludeCommands.java b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport_excludeCommands.java
index de98b893541..65d61cd0315 100644
--- a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport_excludeCommands.java
+++ b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport_excludeCommands.java
@@ -92,7 +92,7 @@ public String validateSelected(final List<ReplayableCommand> selected) {
@MemberSupport
public List<ReplayableCommand> defaultSelected() {
return commandExportManager.getCommands().stream()
- .filter(command -> Boolean.FALSE.equals(command.getExportable()))
+ .filter(command -> Boolean.FALSE.equals(command.isKnownParticipants()))
.collect(Collectors.toList());
}
diff --git a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport_exportSelected.java b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport_exportSelected.java
index fbbbaecba81..9fd6b306390 100644
--- a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport_exportSelected.java
+++ b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandManagerExport_exportSelected.java
@@ -107,7 +107,7 @@ public boolean defaultFilenameTimestamp() {
@MemberSupport
public List<ReplayableCommand> defaultSelected() {
return commandExportManager.getCommands().stream()
- .filter(command -> Boolean.TRUE.equals(command.getExportable()))
+ .filter(command -> Boolean.TRUE.equals(command.isKnownParticipants()))
.collect(Collectors.toList());
}
diff --git a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.columnOrder.fallback.txt b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.columnOrder.fallback.txt
index e78a9abe4d7..ad3b55fd9dd 100644
--- a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.columnOrder.fallback.txt
+++ b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.columnOrder.fallback.txt
@@ -4,4 +4,4 @@ target
member
replayState
hasResult
-exportable
\ No newline at end of file
+knownParticipants
\ No newline at end of file
diff --git a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.java b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.java
index f26ba5ffe35..1c288190962 100644
--- a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.java
+++ b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.java
@@ -114,10 +114,6 @@ public ReplayContext replayContext() {
private final ObjectReference<CommandRecord> recordRef;
- @Programmatic
- public ObjectReference<CommandRecord> recordRef() {
- return recordRef;
- }
private final CommandManagerExport commandExportManager;
@@ -344,15 +340,15 @@ public boolean getHasResult() {
@PropertyLayout(
sequence = "4.2",
fieldSetId = "details",
- describedAs = "Whether this command is exportable from the current command export manager context.",
+ describedAs = "Whether this command uses only known participants as target or action params. This determines whether the command is exportable/replayable in context of all commands since a baseline.",
hidden = Where.OBJECT_FORMS
)
- public Boolean getExportable() {
+ public Boolean isKnownParticipants() {
if (commandExportManager == null) {
return null;
}
return commandLogEntry()
- .map(commandExportManager::isExportable)
+ .map(commandExportManager::isKnownParticipants)
.orElse(null);
}
diff --git a/extensions/core/commandlog/applib/src/test/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandExportManagerSelectedTestExport.java b/extensions/core/commandlog/applib/src/test/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandExportManagerSelectedTestExport.java
index cf216f24a8a..2f6065148d0 100644
--- a/extensions/core/commandlog/applib/src/test/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandExportManagerSelectedTestExport.java
+++ b/extensions/core/commandlog/applib/src/test/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/CommandExportManagerSelectedTestExport.java
@@ -190,7 +190,7 @@ void act_guards_unknown_action_reference_parameter_when_ui_validation_is_bypasse
void exportable_is_true_for_first_domain_service_target_in_export_manager_context() {
final var commands = exportManagerCommandsWith(entry(T1, MENU_SERVICE));
- assertThat(commands.get(0).getExportable()).isTrue();
+ assertThat(commands.get(0).isKnownParticipants()).isTrue();
}
@Test
@@ -199,21 +199,21 @@ void exportable_is_true_for_command_with_known_target_in_export_manager_context(
final var actionOnFoundCustomer = entry(Timestamp.from(Instant.parse("2026-06-07T10:00:02Z")), CUSTOMER, null);
final var commands = exportManagerCommandsWith(finder, actionOnFoundCustomer);
- assertThat(commands.get(1).getExportable()).isTrue();
+ assertThat(commands.get(1).isKnownParticipants()).isTrue();
}
@Test
void exportable_is_false_for_command_with_unknown_target_in_export_manager_context() {
final var commands = exportManagerCommandsWith(entry(T1, CUSTOMER));
- assertThat(commands.get(0).getExportable()).isFalse();
+ assertThat(commands.get(0).isKnownParticipants()).isFalse();
}
@Test
void exportable_is_false_for_property_edit_with_unknown_target_in_export_manager_context() {
final var commands = exportManagerCommandsWith(propertyEditEntry(T1, CUSTOMER));
- assertThat(commands.get(0).getExportable()).isFalse();
+ assertThat(commands.get(0).isKnownParticipants()).isFalse();
}
@Test
@@ -222,7 +222,7 @@ void exportable_is_false_when_required_result_is_later_in_export_order() {
final var laterFinder = entry(Timestamp.from(Instant.parse("2026-06-07T10:00:02Z")), MENU_SERVICE, CUSTOMER);
final var commands = exportManagerCommandsWith(actionOnCustomer, laterFinder);
- assertThat(commands.get(0).getExportable()).isFalse();
+ assertThat(commands.get(0).isKnownParticipants()).isFalse();
}
@Test
@@ -232,16 +232,16 @@ void earlier_non_exportable_command_does_not_make_later_known_command_non_export
final var actionOnFoundCustomer = entry(Timestamp.from(Instant.parse("2026-06-07T10:00:03Z")), CUSTOMER, null);
final var commands = exportManagerCommandsWith(unknownCustomerAction, finder, actionOnFoundCustomer);
- assertThat(commands.get(0).getExportable()).isFalse();
- assertThat(commands.get(1).getExportable()).isTrue();
- assertThat(commands.get(2).getExportable()).isTrue();
+ assertThat(commands.get(0).isKnownParticipants()).isFalse();
+ assertThat(commands.get(1).isKnownParticipants()).isTrue();
+ assertThat(commands.get(2).isKnownParticipants()).isTrue();
}
@Test
void exportable_is_null_when_recording_support_is_disabled() {
final var commands = exportManagerCommandsWithRecordingSupport(RecordingSupport.DISABLED, entry(T1, CUSTOMER));
- assertThat(commands.get(0).getExportable()).isNull();
+ assertThat(commands.get(0).isKnownParticipants()).isNull();
}
@Test
@@ -253,7 +253,7 @@ void exportable_is_null_outside_export_manager_context() {
final var command = new ReplayableCommand(entry.getInteractionId(), replayContext);
- assertThat(command.getExportable()).isNull();
+ assertThat(command.isKnownParticipants()).isNull();
}
@Test
@@ -261,7 +261,7 @@ void exportable_computation_does_not_modify_replay_state() {
final var entry = entry(T1, CUSTOMER);
final var commands = exportManagerCommandsWith(entry);
- assertThat(commands.get(0).getExportable()).isFalse();
+ assertThat(commands.get(0).isKnownParticipants()).isFalse();
verify(entry, org.mockito.Mockito.never()).setReplayState(org.mockito.Mockito.any());
}
diff --git a/extensions/core/commandlog/applib/src/test/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommandMappingTest.java b/extensions/core/commandlog/applib/src/test/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommandMappingTest.java
index 3446b028c59..37deff5e525 100644
--- a/extensions/core/commandlog/applib/src/test/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommandMappingTest.java
+++ b/extensions/core/commandlog/applib/src/test/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommandMappingTest.java
@@ -856,7 +856,7 @@ void has_result_does_not_require_result_bookmark_to_resolve_locally() {
void has_result_property_is_ordered_before_exportability_in_tables() throws Exception {
PropertyLayout hasResultLayout = ReplayableCommand.class.getMethod("getHasResult")
.getAnnotation(PropertyLayout.class);
- PropertyLayout exportableLayout = ReplayableCommand.class.getMethod("getExportable")
+ PropertyLayout exportableLayout = ReplayableCommand.class.getMethod("isKnownParticipants")
.getAnnotation(PropertyLayout.class);
assertThat(hasResultLayout.sequence()).isEqualTo("4.1");