[GitHub] [incubator-superset] eschutho commented on a change in pull request #10847: update port that cypress runs on for local vs test

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#discussion_r488257207



##########
File path: superset-frontend/cypress-base/package.json
##########
@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "description": "run cypress against superset",
   "scripts": {
-    "cypress": "cypress",
+    "cypress": "CYPRESS_BASE_URL=\"http://localhost:${npm_config_port:-8088}\" cypress",

Review comment:
       This isn't necessary, but an extra addition to potentially minimize confusion for engineers that have an existing cypress test workflow and aren't running on port 8088. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org