You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by th...@apache.org on 2017/05/15 02:32:31 UTC

hive git commit: HIVE-15725 : Make it possible to run checkstyle for a specific module (Peter Vary via Thejas Nair)

Repository: hive
Updated Branches:
  refs/heads/master 877bbf0e5 -> c90aa83fb


HIVE-15725 : Make it possible to run checkstyle for a specific module (Peter Vary via Thejas Nair)


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/c90aa83f
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/c90aa83f
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/c90aa83f

Branch: refs/heads/master
Commit: c90aa83fbefe256288ef5df8a2d10b0e355f4795
Parents: 877bbf0
Author: Peter Vary <pv...@cloudera.com>
Authored: Sun May 14 19:32:20 2017 -0700
Committer: Thejas M Nair <th...@hortonworks.com>
Committed: Sun May 14 19:32:20 2017 -0700

----------------------------------------------------------------------
 checkstyle/checkstyle.xml | 4 ++--
 pom.xml                   | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/c90aa83f/checkstyle/checkstyle.xml
----------------------------------------------------------------------
diff --git a/checkstyle/checkstyle.xml b/checkstyle/checkstyle.xml
index 1c5b305..bd6b2f8 100644
--- a/checkstyle/checkstyle.xml
+++ b/checkstyle/checkstyle.xml
@@ -65,7 +65,7 @@
   <module name="Translation"/>
 
   <module name="Header">
-    <property name="headerFile" value="checkstyle/asf.header"/>
+    <property name="headerFile" value="${basedir}/asf.header"/>
   </module>
 
   <!-- Maximum file line length -->
@@ -78,7 +78,7 @@
 
   <!-- List of files to ignore -->
   <module name="SuppressionFilter">
-    <property name="file" value="checkstyle/suppressions.xml"/>
+    <property name="file" value="${basedir}/suppressions.xml"/>
   </module>
 
   <!-- Ignore JavaCC/JJTree files -->

http://git-wip-us.apache.org/repos/asf/hive/blob/c90aa83f/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index e0aae27..30fa50b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -71,7 +71,7 @@
     <maven.repo.local>${settings.localRepository}</maven.repo.local>
     <hive.path.to.root>.</hive.path.to.root>
     <hive.jdbc.driver.classifier>standalone</hive.jdbc.driver.classifier>
-    <checkstyle.conf.dir>${hive.path.to.root}/checkstyle</checkstyle.conf.dir>
+    <checkstyle.conf.dir>${basedir}/${hive.path.to.root}/checkstyle</checkstyle.conf.dir>
 
     <!-- Test Properties -->
     <test.extra.path></test.extra.path>
@@ -1056,6 +1056,7 @@
         <artifactId>maven-checkstyle-plugin</artifactId>
         <configuration>
           <configLocation>${checkstyle.conf.dir}/checkstyle.xml</configLocation>
+          <propertyExpansion>basedir=${checkstyle.conf.dir}</propertyExpansion>
         </configuration>
       </plugin>
       <plugin>