You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/28 10:22:04 UTC
[jira] [Commented] (FLINK-6411) YarnApplicationMasterRunner should
not interfere with RunningJobsRegistry
[ https://issues.apache.org/jira/browse/FLINK-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988598#comment-15988598 ]
ASF GitHub Bot commented on FLINK-6411:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3797
[FLINK-6411] [flip-6] Remove job removal from RunningJobsRegistry in YarnFlinkApplicationMasterRunner.shutdown
The YarnFlinkApplicationMasterRunner should not be concerned with removing jobs from
the RunningJobsRegistry. This is the responsibility of the JobManagerRunner.
This PR removes the job removal from the RunningJobRegistry from the
YarnFlinkApplicationMasterRunner.shutdown method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink FLINK-6411
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3797.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3797
----
commit 6dca3b8308ebd703b7f98da4780c9180184a4af4
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-04-28T10:17:42Z
[FLINK-6411] [flip-6] Remove job removal from RunningJobsRegistry in YarnFlinkApplicationMasterRunner.shutdown
The YarnFlinkApplicationMasterRunner should not be concerned with removing jobs from
the RunningJobsRegistry. This is the responsibility of the JobManagerRunner.
This PR removes the job removal from the RunningJobRegistry from the
YarnFlinkApplicationMasterRunner.shutdown method.
----
> YarnApplicationMasterRunner should not interfere with RunningJobsRegistry
> -------------------------------------------------------------------------
>
> Key: FLINK-6411
> URL: https://issues.apache.org/jira/browse/FLINK-6411
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.3.0
>
>
> The {{YarnApplicationMasterRunner}} removes the running job from the {{RunningJobsRegistry}} when it is shut down. This should not be its responsibility and rather be delegated to the {{JobManagerRunner}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)