You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2015/05/05 19:35:07 UTC
[1/4] [lang] Fix SonarQube warning:
org.apache.commons.lang3.ClassUtils.()
makes inefficient use of keySet iterator instead of entrySet iterator.
Repository: commons-lang
Updated Branches:
refs/heads/master fc73151cf -> 98220ad03
Fix SonarQube warning: org.apache.commons.lang3.ClassUtils.<static initializer for ClassUtils>()
makes inefficient use of keySet iterator instead of entrySet iterator.
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/8d0214a7
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/8d0214a7
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/8d0214a7
Branch: refs/heads/master
Commit: 8d0214a7417addf790713440f10855dc279876fa
Parents: 1cb5573
Author: Benedikt Ritter <br...@apache.org>
Authored: Tue May 5 18:54:53 2015 +0200
Committer: Benedikt Ritter <br...@apache.org>
Committed: Tue May 5 18:58:13 2015 +0200
----------------------------------------------------------------------
src/main/java/org/apache/commons/lang3/ClassUtils.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/8d0214a7/src/main/java/org/apache/commons/lang3/ClassUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/ClassUtils.java b/src/main/java/org/apache/commons/lang3/ClassUtils.java
index 92ecb15..c56aeab 100644
--- a/src/main/java/org/apache/commons/lang3/ClassUtils.java
+++ b/src/main/java/org/apache/commons/lang3/ClassUtils.java
@@ -94,8 +94,9 @@ public class ClassUtils {
*/
private static final Map<Class<?>, Class<?>> wrapperPrimitiveMap = new HashMap<Class<?>, Class<?>>();
static {
- for (final Class<?> primitiveClass : primitiveWrapperMap.keySet()) {
- final Class<?> wrapperClass = primitiveWrapperMap.get(primitiveClass);
+ for (final Map.Entry<Class<?>, Class<?>> entry : primitiveWrapperMap.entrySet()) {
+ final Class<?> primitiveClass = entry.getKey();
+ final Class<?> wrapperClass = entry.getValue();
if (!primitiveClass.equals(wrapperClass)) {
wrapperPrimitiveMap.put(wrapperClass, primitiveClass);
}
[4/4] [lang] Merge branch 'LANG-1130'
Posted by br...@apache.org.
Merge branch 'LANG-1130'
LANG-1130: Fix critical issues reported by SonarQube.
Fixed critical issues in ClassUtils and TypeUtils. The
other three issues are false positives.
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/98220ad0
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/98220ad0
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/98220ad0
Branch: refs/heads/master
Commit: 98220ad03e4b620a98ca355317c9da6c6ac765d1
Parents: fc73151 b162f51
Author: Benedikt Ritter <br...@apache.org>
Authored: Tue May 5 19:33:28 2015 +0200
Committer: Benedikt Ritter <br...@apache.org>
Committed: Tue May 5 19:33:28 2015 +0200
----------------------------------------------------------------------
src/changes/changes.xml | 1 +
src/main/java/org/apache/commons/lang3/ClassUtils.java | 5 +++--
src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/98220ad0/src/changes/changes.xml
----------------------------------------------------------------------
diff --cc src/changes/changes.xml
index 2081591,9b596ce..3523968
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@@ -22,7 -22,7 +22,8 @@@
<body>
<release version="3.5" date="tba" description="tba">
+ <action issue="LANG-1130" type="fix" dev="britter">Fix critical issues reported by SonarQube</action>
+ <action issue="LANG-1131" type="fix" dev="britter">StrBuilder.equals(StrBuilder) doesn't check for null inputs</action>
<action issue="LANG-1105" type="add" dev="britter" due-to="Hendrik Saly">Add ThreadUtils - A utility class which provides helper methods related to java.lang.Thread</action>
<action issue="LANG-1031" type="add" dev="britter" due-to="Felipe Adorno">Add annotations to exclude fields from ReflectionEqualsBuilder, ReflectionToStringBuilder and ReflectionHashCodeBuilder</action>
<action issue="LANG-1127" type="add" dev="chas">Unit test helpers which set and reset default Locale and TimeZone</action>
[2/4] [lang] Fix SonarQube warning: The user-supplied array
'typeArguments' is stored directly.
Posted by br...@apache.org.
Fix SonarQube warning: The user-supplied array 'typeArguments' is stored directly.
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/7af67bdd
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/7af67bdd
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/7af67bdd
Branch: refs/heads/master
Commit: 7af67bdd16a4f103bbe6334c5a865436c900adfe
Parents: 8d0214a
Author: Benedikt Ritter <br...@apache.org>
Authored: Tue May 5 18:58:41 2015 +0200
Committer: Benedikt Ritter <br...@apache.org>
Committed: Tue May 5 18:58:41 2015 +0200
----------------------------------------------------------------------
src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/7af67bdd/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java b/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
index 91313c6..62a2380 100644
--- a/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
+++ b/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
@@ -157,7 +157,7 @@ public class TypeUtils {
private ParameterizedTypeImpl(final Class<?> raw, final Type useOwner, final Type[] typeArguments) {
this.raw = raw;
this.useOwner = useOwner;
- this.typeArguments = typeArguments;
+ this.typeArguments = typeArguments.clone();
}
/**
[3/4] [lang] Add LANG-1130 to changes.xml
Posted by br...@apache.org.
Add LANG-1130 to changes.xml
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/b162f51a
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/b162f51a
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/b162f51a
Branch: refs/heads/master
Commit: b162f51adce077dc4cad631fd02cc9cd82eaff6f
Parents: 7af67bd
Author: Benedikt Ritter <br...@apache.org>
Authored: Tue May 5 19:32:50 2015 +0200
Committer: Benedikt Ritter <br...@apache.org>
Committed: Tue May 5 19:32:50 2015 +0200
----------------------------------------------------------------------
src/changes/changes.xml | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/b162f51a/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index f151745..9b596ce 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -22,6 +22,7 @@
<body>
<release version="3.5" date="tba" description="tba">
+ <action issue="LANG-1130" type="fix" dev="britter">Fix critical issues reported by SonarQube</action>
<action issue="LANG-1105" type="add" dev="britter" due-to="Hendrik Saly">Add ThreadUtils - A utility class which provides helper methods related to java.lang.Thread</action>
<action issue="LANG-1031" type="add" dev="britter" due-to="Felipe Adorno">Add annotations to exclude fields from ReflectionEqualsBuilder, ReflectionToStringBuilder and ReflectionHashCodeBuilder</action>
<action issue="LANG-1127" type="add" dev="chas">Unit test helpers which set and reset default Locale and TimeZone</action>