You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "apupier (via GitHub)" <gi...@apache.org> on 2026/09/03 11:08:23 UTC

[PR] Revert "[JBANG-IT] Add cleanups for tests that can produce state leaks" [camel]

apupier opened a new pull request, #26082:
URL: https://github.com/apache/camel/pull/26082

   Reverts apache/camel#25948
   
   intent was good but it broke several tests https://ci-builds.apache.org/job/Camel/job/Camel%20Jbang%20IT%20Tests/job/main/lastCompletedBuild/testReport/
   
   
   for instance:
   ```
   org.opentest4j.AssertionFailedError: 
   command camel plugin delete validate was expected to fail but succeeded with output Plugin validate removed
    and error 
   	at org.junit.jupiter.api.Assertions.fail(Assertions.java:142)
   	at org.apache.camel.test.infra.cli.services.CliLocalContainerService.executeGenericCommand(CliLocalContainerService.java:170)
   	at org.apache.camel.test.infra.cli.services.CliLocalContainerService.execute(CliLocalContainerService.java:132)
   	at org.apache.camel.test.infra.cli.services.CliServiceFactory$SingletonCliService.execute(CliServiceFactory.java:38)
   	at org.apache.camel.dsl.jbang.it.support.JBangTestSupport.execute(JBangTestSupport.java:148)
   	at org.apache.camel.dsl.jbang.it.ValidatePluginITCase.removeValidatePlugin(ValidatePluginITCase.java:29)
   ```
   
   ```
   org.opentest4j.AssertionFailedError: 
   command camel plugin delete validate was expected to fail but succeeded with output Plugin validate removed
    and error 
   	at org.junit.jupiter.api.Assertions.fail(Assertions.java:142)
   	at org.apache.camel.test.infra.cli.services.CliLocalContainerService.executeGenericCommand(CliLocalContainerService.java:170)
   	at org.apache.camel.test.infra.cli.services.CliLocalContainerService.execute(CliLocalContainerService.java:132)
   	at org.apache.camel.test.infra.cli.services.CliServiceFactory$SingletonCliService.execute(CliServiceFactory.java:38)
   	at org.apache.camel.dsl.jbang.it.support.JBangTestSupport.execute(JBangTestSupport.java:148)
   	at org.apache.camel.dsl.jbang.it.ValidatePluginITCase.removeValidatePlugin(ValidatePluginITCase.java:29)
   ```
   
   ```
   org.awaitility.core.ConditionTimeoutException: 
   Assertion condition defined as a Lambda expression in org.apache.camel.dsl.jbang.it.JolokiaITCase command curl http://localhost:8888/hawtio/ failed with output  and error   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                    Dload  Upload   Total   Spent    Left  Speed
   
     0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
     0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
   curl: (7) Failed to connect to localhost port 8888 after 28 ms: Could not connect to server
    within 30 seconds.
   	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
   	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
   	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
   	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
   	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
   	at org.apache.camel.dsl.jbang.it.JolokiaITCase.testRunHawtio(JolokiaITCase.java:66)
   	Suppressed: org.opentest4j.AssertionFailedError: command camel stop FromDirectoryRoute was expected to fail but succeeded with output Shutting down Camel integration (PID: 1535)
    and error 
   		at org.junit.jupiter.api.Assertions.fail(Assertions.java:142)
   		at org.apache.camel.test.infra.cli.services.CliLocalContainerService.executeGenericCommand(CliLocalContainerService.java:170)
   		at org.apache.camel.test.infra.cli.services.CliLocalContainerService.execute(CliLocalContainerService.java:132)
   		at org.apache.camel.test.infra.cli.services.CliServiceFactory$SingletonCliService.execute(CliServiceFactory.java:38)
   		at org.apache.camel.dsl.jbang.it.support.JBangTestSupport.execute(JBangTestSupport.java:148)
   		at org.apache.camel.dsl.jbang.it.JolokiaITCase.stopJolokiaAndHawtio(JolokiaITCase.java:40)
   Caused by: java.util.concurrent.TimeoutException
   	at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:206)
   	at org.awaitility.core.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:101)
   	at org.awaitility.core.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:81)
   	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:103)
   	... 5 more
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "[JBANG-IT] Add cleanups for tests that can produce state leaks" [camel]

Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier merged PR #26082:
URL: https://github.com/apache/camel/pull/26082


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "[JBANG-IT] Add cleanups for tests that can produce state leaks" [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26082:
URL: https://github.com/apache/camel/pull/26082#issuecomment-5525029507

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `dsl/camel-jbang/camel-jbang-it`
   
   ---
   
   <details><summary>:microscope: Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 0 all tested</summary>
   
   [Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **1 affected modules** (current approach: 0).
   
   <details><summary>:warning: Modules only in Scalpel (1)</summary>
   
   - `camel-jbang-it`
   
   </details>
   
   **Skip-tests mode would test 1 modules** (1 direct + 0 downstream), **skip tests for 0** (generated code, meta-modules)
   
   <details><summary>Modules Scalpel would test (1)</summary>
   
   - `camel-jbang-it`
   
   </details>
   
   > :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
   
   </details>
   
   :warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
   
   - `dsl/camel-jbang/camel-jbang-it`: 1 test(s) disabled on GitHub Actions
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/33748051560)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "[JBANG-IT] Add cleanups for tests that can produce state leaks" [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26082:
URL: https://github.com/apache/camel/pull/26082#issuecomment-5524865225

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org