You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/10 16:32:26 UTC
[GitHub] [flink] dawidwys commented on a change in pull request #11034:
[FLINK-15802][table] Support new type inference for table functions
dawidwys commented on a change in pull request #11034: [FLINK-15802][table] Support new type inference for table functions
URL: https://github.com/apache/flink/pull/11034#discussion_r377081317
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/catalog/FunctionCatalogOperatorTable.java
##########
@@ -145,12 +145,18 @@ public void lookupOperatorOverloads(
}
}
// new stack
- return convertToBridgingSqlFunction(identifier, definition);
+ return convertToBridgingSqlFunction(category, identifier, definition);
}
private Optional<SqlFunction> convertToBridgingSqlFunction(
+ @Nullable SqlFunctionCategory category,
FunctionIdentifier identifier,
FunctionDefinition definition) {
+
+ if (!verifyFunctionKind(category, definition)) {
Review comment:
This makes the line 177 unreachable. Can we have a comment why is it so? Is it because we do not support aggregate functions in code generator yet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services