You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/09/21 09:17:55 UTC
[PR] CAMEL-24869: camel-jbang - validator hint for sql queries with :name parameters (camel-sql uses :#name) [camel]
davsclaus opened a new pull request, #26672:
URL: https://github.com/apache/camel/pull/26672
Fixes https://issues.apache.org/jira/browse/CAMEL-24869
A `:name` in a sql endpoint query that is not the camel-sql `:#name` (a header or a key of a Map body) or `:#${simple}` form goes to the JDBC driver as written and fails at runtime with a syntax error, after the file consumer retried it a hundred times. The validator (`camel validate`, `camel_validate_source`, `camel_write_file`) now names the parameter and says how to write it:
```
Line 8: sql: :customer is not a camel-sql named parameter (the JDBC driver gets it as written and fails with a syntax error): write :#customer for a header or a key of a Map body, or :#${body[customer]} with a Simple expression (also :country)
```
It covers the query under `parameters:` and the `sql:SELECT ...` path (the uri pattern stops at the first space, so the statement is taken from the line). `::type` casts, `:?name` stored procedure parameters, `:#...` and times such as `'10:30'` are left alone; `sql-stored` and `jdbc` are not checked (their statements have other forms).
Seen in the camel-jbang-mcp server stepwise benchmark on the sql example: five of six first statements of the local model used `:customer` or `:body[customer]`. Tests: `SourceValidatorSqlParametersTest`; every documentation example still passes `CatalogDocExamplesTest`.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01Bp3538HRBPMQkb5ta9xRaj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24869: camel-jbang - validator hint for sql queries with :name parameters (camel-sql uses :#name) [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #26672:
URL: https://github.com/apache/camel/pull/26672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24869: camel-jbang - validator hint for sql queries with :name parameters (camel-sql uses :#name) [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26672:
URL: https://github.com/apache/camel/pull/26672#issuecomment-5758167458
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24869: camel-jbang - validator hint for sql queries with :name parameters (camel-sql uses :#name) [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26672:
URL: https://github.com/apache/camel/pull/26672#issuecomment-5758514038
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-jbang/camel-jbang-core`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 6 of 692 tested, 8 compile-only — current: 6 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **15 affected modules** (current approach: 6).
**Skip-tests mode would test 6 modules** (1 direct + 6 downstream), **skip tests for 8** (generated code, meta-modules)
<details><summary>:warning: Modules only in Scalpel (9)</summary>
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-launcher`
- `coverage`
</details>
<details><summary>Modules Scalpel would test (6)</summary>
- `camel-jbang-core` ← dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ai/EndpointChecks.java, dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/commands/ai/SourceValidatorSqlParametersTest.java
- `camel-jbang-mcp` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-mcp` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-route-parser` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-tui` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-validate` ← downstream of org.apache.camel:camel-jbang-core
- `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
</details>
<details><summary>Modules with tests skipped (8)</summary>
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-launcher`
- `coverage`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
:warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
- `dsl/camel-jbang/camel-jbang-core`: 2 test(s) disabled on GitHub Actions
:bulb: **Manual integration tests recommended:**
> You modified `dsl/camel-jbang/camel-jbang-core`. The related integration tests in `dsl/camel-jbang/camel-jbang-it` are excluded from CI. Consider running them manually:
> ```
> mvn verify -f dsl/camel-jbang/camel-jbang-it -Djbang-it-test
> ```
<details><summary>All tested modules (15 modules, 2m 54s total)</summary>
**Total reactor time:** 2m 54s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: Launcher | 50.8s | SUCCESS |
| Camel :: JBang :: MCP | 42.5s | SUCCESS |
| Camel :: JBang :: Plugin :: TUI | 35.9s | SUCCESS |
| Camel :: JBang :: Plugin :: Kubernetes | 15.5s | SUCCESS |
| Camel :: JBang :: Plugin :: Testing | 9.1s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 6.0s | SUCCESS |
| Camel :: Coverage | 4.4s | SUCCESS |
| Camel :: JBang :: Plugin :: Edit | 3.8s | SUCCESS |
| Camel :: JBang :: Plugin :: Generate | 1.3s | SUCCESS |
| Camel :: JBang :: Main | 1.2s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 1.2s | SUCCESS |
| Camel :: JBang :: Plugin :: Route Parser | 1.0s | SUCCESS |
| Camel :: JBang :: Integration tests | 0.9s | SUCCESS |
| Camel :: Launcher :: Container | 0.7s | SUCCESS |
| Camel :: JBang :: Core | n/a | |
**Top 20 slowest modules:**
- `Camel :: Launcher` (50.8s)
- `Camel :: JBang :: MCP` (42.5s)
- `Camel :: JBang :: Plugin :: TUI` (35.9s)
- `Camel :: JBang :: Plugin :: Kubernetes` (15.5s)
- `Camel :: JBang :: Plugin :: Testing` (9.1s)
- `Camel :: JBang :: Plugin :: Validate` (6.0s)
- `Camel :: Coverage` (4.4s)
- `Camel :: JBang :: Plugin :: Edit` (3.8s)
- `Camel :: JBang :: Plugin :: Generate` (1.3s)
- `Camel :: JBang :: Main` (1.2s)
- `Camel :: JBang :: Plugin :: MCP` (1.2s)
- `Camel :: JBang :: Plugin :: Route Parser` (1.0s)
- `Camel :: JBang :: Integration tests` (0.9s)
- `Camel :: Launcher :: Container` (0.7s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/35582472939)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org