You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/08 07:12:35 UTC
[GitHub] [spark] dchvn opened a new pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
dchvn opened a new pull request #34515:
URL: https://github.com/apache/spark/pull/34515
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->We can take advantage of static type checking within the functions by inlining the type hints.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->Existing Tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34515:
URL: https://github.com/apache/spark/pull/34515#discussion_r744655260
##########
File path: python/pyspark/mllib/stat/distribution.py
##########
@@ -15,12 +15,14 @@
# limitations under the License.
#
-from collections import namedtuple
-
__all__ = ['MultivariateGaussian']
+from typing import NamedTuple
+
+from pyspark.mllib.linalg import Matrix, Vector
+
-class MultivariateGaussian(namedtuple('MultivariateGaussian', ['mu', 'sigma'])):
+class MultivariateGaussian(NamedTuple):
Review comment:
Oh, okay, it was my bad. I didn't reliased that the typing annotation can be same https://docs.python.org/3/library/typing.html#typing.NamedTuple. Resolving this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-962984485
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49461/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34515:
URL: https://github.com/apache/spark/pull/34515#discussion_r744656102
##########
File path: python/pyspark/mllib/stat/__init__.pyi
##########
@@ -1,29 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-from pyspark.mllib.stat.KernelDensity import ( # noqa: F401
- KernelDensity as KernelDensity,
-)
-from pyspark.mllib.stat._statistics import ( # noqa: F401
- MultivariateStatisticalSummary as MultivariateStatisticalSummary,
- Statistics as Statistics,
-)
-from pyspark.mllib.stat.distribution import ( # noqa: F401
- MultivariateGaussian as MultivariateGaussian,
-)
-from pyspark.mllib.stat.test import ChiSqTestResult as ChiSqTestResult # noqa: F401
Review comment:
Is this safe to remove, @zero323?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34515:
URL: https://github.com/apache/spark/pull/34515#discussion_r745206215
##########
File path: python/pyspark/mllib/stat/__init__.pyi
##########
@@ -1,29 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-from pyspark.mllib.stat.KernelDensity import ( # noqa: F401
- KernelDensity as KernelDensity,
-)
-from pyspark.mllib.stat._statistics import ( # noqa: F401
- MultivariateStatisticalSummary as MultivariateStatisticalSummary,
- Statistics as Statistics,
-)
-from pyspark.mllib.stat.distribution import ( # noqa: F401
- MultivariateGaussian as MultivariateGaussian,
-)
-from pyspark.mllib.stat.test import ChiSqTestResult as ChiSqTestResult # noqa: F401
Review comment:
Seem like it @HyukjinKwon. There is nothing here, that we cannot pick out of `py` file.
##########
File path: python/pyspark/mllib/stat/__init__.pyi
##########
@@ -1,29 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-from pyspark.mllib.stat.KernelDensity import ( # noqa: F401
- KernelDensity as KernelDensity,
-)
-from pyspark.mllib.stat._statistics import ( # noqa: F401
- MultivariateStatisticalSummary as MultivariateStatisticalSummary,
- Statistics as Statistics,
-)
-from pyspark.mllib.stat.distribution import ( # noqa: F401
- MultivariateGaussian as MultivariateGaussian,
-)
-from pyspark.mllib.stat.test import ChiSqTestResult as ChiSqTestResult # noqa: F401
Review comment:
Seem like it @HyukjinKwon. There is nothing here, that we cannot pick out of the `py` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-962884424
**[Test build #144989 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144989/testReport)** for PR 34515 at commit [`3691b69`](https://github.com/apache/spark/commit/3691b69187aeb8edbf8829047a7891eb066e5b36).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class MultivariateGaussian(NamedTuple):`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on a change in pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on a change in pull request #34515:
URL: https://github.com/apache/spark/pull/34515#discussion_r744633543
##########
File path: python/pyspark/mllib/stat/distribution.py
##########
@@ -15,12 +15,14 @@
# limitations under the License.
#
-from collections import namedtuple
-
__all__ = ['MultivariateGaussian']
+from typing import NamedTuple
+
+from pyspark.mllib.linalg import Matrix, Vector
+
-class MultivariateGaussian(namedtuple('MultivariateGaussian', ['mu', 'sigma'])):
+class MultivariateGaussian(NamedTuple):
Review comment:
Please take a look at https://github.com/apache/spark/pull/34375#discussion_r738143060 .
I followed that one. Are they different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-964710557
> Hey, @dchvn, it would be great to double check and update your old PRs before opening new ones. Many of them are missing details like that and it takes more time to review ...
Please see my old PRs and give me your opinions! I have updated with reviewers' comments! Many thanks 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34515:
URL: https://github.com/apache/spark/pull/34515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-963045390
Hey, @dchvn, it would be great to double check and update your old PRs before opening new ones. Many of them are missing details like that and it takes more time to review ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-962872311
**[Test build #144989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144989/testReport)** for PR 34515 at commit [`3691b69`](https://github.com/apache/spark/commit/3691b69187aeb8edbf8829047a7891eb066e5b36).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-963046213
Also it would be much easier to review if you add some justification on `ignore`s or unusual code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn edited a comment on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
dchvn edited a comment on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-964710557
> Hey, @dchvn, it would be great to double check and update your old PRs before opening new ones. Many of them are missing details like that and it takes more time to review ...
Please see my old PRs and give me your opinions! I have updated with reviewers' comments! Many thanks 😄 @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-962872311
**[Test build #144989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144989/testReport)** for PR 34515 at commit [`3691b69`](https://github.com/apache/spark/commit/3691b69187aeb8edbf8829047a7891eb066e5b36).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34515:
URL: https://github.com/apache/spark/pull/34515#discussion_r744620552
##########
File path: python/pyspark/mllib/stat/distribution.py
##########
@@ -15,12 +15,14 @@
# limitations under the License.
#
-from collections import namedtuple
-
__all__ = ['MultivariateGaussian']
+from typing import NamedTuple
+
+from pyspark.mllib.linalg import Matrix, Vector
+
-class MultivariateGaussian(namedtuple('MultivariateGaussian', ['mu', 'sigma'])):
+class MultivariateGaussian(NamedTuple):
Review comment:
Hm, is't it a breaking change? Previously it inherited an actual named tuple that works like named tuple. Now it inherits the typing class of `NamedTuple`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34515:
URL: https://github.com/apache/spark/pull/34515#discussion_r744621817
##########
File path: python/pyspark/mllib/stat/distribution.py
##########
@@ -15,12 +15,14 @@
# limitations under the License.
#
-from collections import namedtuple
-
__all__ = ['MultivariateGaussian']
+from typing import NamedTuple
+
+from pyspark.mllib.linalg import Matrix, Vector
+
-class MultivariateGaussian(namedtuple('MultivariateGaussian', ['mu', 'sigma'])):
+class MultivariateGaussian(NamedTuple):
Review comment:
for example, does it work when you do `list(MultivariateGaussian())`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-963731088
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-962932815
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49461/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-962984485
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49461/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-962895477
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144989/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-962895477
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144989/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34515:
URL: https://github.com/apache/spark/pull/34515#issuecomment-962967073
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49461/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org