svn commit: r540665 - in /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types: DataValueDescriptor.java DataValueFactory.java

[dj...@apache.org]

Author: djd
Date: Tue May 22 10:58:55 2007
New Revision: 540665

URL: http://svn.apache.org/viewvc?view=rev&rev=540665
Log:
Improve some comments for DataValueFactory.getCharValue() and DataValueDescriptor.

Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueDescriptor.java
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueFactory.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueDescriptor.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueDescriptor.java?view=diff&rev=540665&r1=540664&r2=540665
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueDescriptor.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueDescriptor.java Tue May 22 10:58:55 2007
@@ -39,10 +39,7 @@
 
 /**
  * The DataValueDescriptor interface provides methods to get the data from
- * a column returned by a statement.  This interface has the same methods
- * as NoCastDataValueDescriptor - the only reason it exists is for purposes
- * of internal documentation, to make it clear when the different getXXX
- * methods throw exceptions for illegal conversions.
+ * a column returned by a statement.
  * <p>
  * This interface matches the getXXX methods on java.sql.ResultSet. This means
  * everyone satisfies getString and getObject; all of the numeric types, within

Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueFactory.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueFactory.java?view=diff&rev=540665&r1=540664&r2=540665
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueFactory.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueFactory.java Tue May 22 10:58:55 2007
@@ -351,12 +351,20 @@
                                                         throws StandardException;
 
         /**
-         * Get a SQL char with the given value.  A null argument means get
-         * a SQL null value.  The second form re-uses the previous value,
-         * if non-null, as the data holder to return.
+         * Get a new SQLChar object to represent a SQL CHAR with the given value.
+         * A null argument means get a SQL NULL value.
          *
          */
         StringDataValue         getCharDataValue(String value);
+        
+        /**
+         * Get a SQLChar object to represent a SQL CHAR with the given value.
+         * A null argument means get a SQL NULL value.
+         * If previous is not null (Java reference) then it will be set
+         * to the value passed in and returned, otherwise a new SQLChar
+         * will be created and set to the value.
+         *
+         */
         StringDataValue         getCharDataValue(String value, StringDataValue previous)
                                                         throws StandardException;