You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/02/23 16:48:36 UTC
[GitHub] [maven-javadoc-plugin] cstamas opened a new pull request, #186: [MJAVADOC-742] Fix resolution of docletArtifacts
cstamas opened a new pull request, #186:
URL: https://github.com/apache/maven-javadoc-plugin/pull/186
Transitive deps were not resovled.
---
https://issues.apache.org/jira/browse/MJAVADOC-742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on pull request #186: [MJAVADOC-742] Fix resolution of docletArtifacts
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #186:
URL: https://github.com/apache/maven-javadoc-plugin/pull/186#issuecomment-1712767765
```
Error: org.apache.maven.plugins.javadoc.JavadocReportTest.testTagletArtifacts -- Time elapsed: 0.728 s <<< ERROR!
java.lang.NullPointerException
at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:361)
at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getArtifactsAbsolutePath(AbstractJavadocMojo.java:3259)
at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getTagletPath(AbstractJavadocMojo.java:2932)
at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addStandardDocletOptions(AbstractJavadocMojo.java:4863)
at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport(AbstractJavadocMojo.java:1957)
at org.apache.maven.plugins.javadoc.JavadocReport.generate(JavadocReport.java:135)
at org.apache.maven.plugins.javadoc.JavadocReport.doExecute(JavadocReport.java:309)
at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.execute(AbstractJavadocMojo.java:1824)
at org.apache.maven.plugins.javadoc.JavadocReportTest.testTagletArtifacts(JavadocReportTest.java:1096)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] cstamas commented on a diff in pull request #186: [MJAVADOC-742] Fix resolution of docletArtifacts
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #186:
URL: https://github.com/apache/maven-javadoc-plugin/pull/186#discussion_r1116004995
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -3242,8 +3241,11 @@ private List<String> getArtifactsAbsolutePath(JavadocPathArtifact javadocArtifac
DependencyFilter filter = new ScopeDependencyFilter(
Arrays.asList(Artifact.SCOPE_COMPILE, Artifact.SCOPE_PROVIDED), Collections.emptySet());
- DependencyRequest req =
- new DependencyRequest(new DefaultDependencyNode(RepositoryUtils.toArtifact(artifact)), filter);
+ DependencyRequest req = new DependencyRequest(
Review Comment:
feel free to take over the PR, I verified it against the user provided reproducer in MJAVADOC-742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] elharo commented on pull request #186: [MJAVADOC-742] Fix resolution of docletArtifacts
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #186:
URL: https://github.com/apache/maven-javadoc-plugin/pull/186#issuecomment-1469883223
Test failures look related:
```
Error: Errors:
Error: JavadocReportTest.testTagletArtifacts:1120 ยป NullPointer
[INFO]
Error: Tests run: 68, Failures: 0, Errors: 1, Skipped: 0
[INFO]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] kwin commented on pull request #186: [MJAVADOC-742] Fix resolution of docletArtifacts
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #186:
URL: https://github.com/apache/maven-javadoc-plugin/pull/186#issuecomment-1713368390
The NPE noted above can only be reproduced on JDK8 (the test works with JDK11 or above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] kwin commented on a diff in pull request #186: [MJAVADOC-742] Fix resolution of docletArtifacts
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #186:
URL: https://github.com/apache/maven-javadoc-plugin/pull/186#discussion_r1116003189
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -3242,8 +3241,11 @@ private List<String> getArtifactsAbsolutePath(JavadocPathArtifact javadocArtifac
DependencyFilter filter = new ScopeDependencyFilter(
Arrays.asList(Artifact.SCOPE_COMPILE, Artifact.SCOPE_PROVIDED), Collections.emptySet());
- DependencyRequest req =
- new DependencyRequest(new DefaultDependencyNode(RepositoryUtils.toArtifact(artifact)), filter);
+ DependencyRequest req = new DependencyRequest(
Review Comment:
Can we add an IT for doclets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] kwin merged pull request #186: [MJAVADOC-742] Fix resolution of docletArtifacts
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #186:
URL: https://github.com/apache/maven-javadoc-plugin/pull/186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] cstamas commented on pull request #186: [MJAVADOC-742] Fix resolution of docletArtifacts
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #186:
URL: https://github.com/apache/maven-javadoc-plugin/pull/186#issuecomment-1714398990
Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org