You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/04/05 20:53:48 UTC
Re: Review Request 45493: Added namespace option to subprocess [3/5].
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45493/#review127182
-----------------------------------------------------------
What is the high-level reasoning for making these namespace specific flags, as opposed to clone flags?
3rdparty/libprocess/include/process/subprocess.hpp (lines 338 - 355)
<https://reviews.apache.org/r/45493/#comment190345>
Can you add a `TODO` here to consider making this `clone_flags` as opposed to `namespaces`?
- Joris Van Remoortere
On March 31, 2016, 10:22 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45493/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 10:22 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-5071
> https://issues.apache.org/jira/browse/MESOS-5071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allows namespaces flags to be passed to subprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp 8a3fe5526f480187441a8aee2c72636bec3e2b2d
> 3rdparty/libprocess/src/subprocess.cpp bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3
>
> Diff: https://reviews.apache.org/r/45493/diff/
>
>
> Testing
> -------
>
> Tested entire chain see https://reviews.apache.org/r/45495/.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 45493: Added namespace option to subprocess [3/5].
Posted by Joerg Schad <jo...@mesosphere.io>.
> On April 5, 2016, 6:53 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, lines 338-355
> > <https://reviews.apache.org/r/45493/diff/2/?file=1320660#file1320660line338>
> >
> > Can you add a `TODO` here to consider making this `clone_flags` as opposed to `namespaces`?
Seeing the comments in the following reviews I actually went ahead and renamed it.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45493/#review127182
-----------------------------------------------------------
On March 31, 2016, 10:22 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45493/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 10:22 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-5071
> https://issues.apache.org/jira/browse/MESOS-5071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allows namespaces flags to be passed to subprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp 8a3fe5526f480187441a8aee2c72636bec3e2b2d
> 3rdparty/libprocess/src/subprocess.cpp bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3
>
> Diff: https://reviews.apache.org/r/45493/diff/
>
>
> Testing
> -------
>
> Tested entire chain see https://reviews.apache.org/r/45495/.
>
>
> Thanks,
>
> Joerg Schad
>
>