You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/01/02 07:10:24 UTC
[GitHub] zeppelin pull request #1833: [ZEPPELIN-1880] Fix shell interpreter output st...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1833
[ZEPPELIN-1880] Fix shell interpreter output streaming result
### What is this PR for?
Shell interpreter streaming output had been available by #683, but currently it's broken after #1087 merged. This patch is for putting it back.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-1880](https://issues.apache.org/jira/browse/ZEPPELIN-1880)
### How should this be tested?
```
%sh
date && sleep 3 && date
```
the each timestamp must be printed as streaming output
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1880
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1833.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1833
----
commit 718873abafdd319ee5e624a2f6afdab2fcb4592c
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-01-02T06:39:14Z
Fix shell intp streaming output result
commit b90b83bed6747d3b92c26f9b6fad89c53e2787b9
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-01-02T06:39:30Z
Add test for shell inpt timeout property
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1833
LGTM it's working well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1833
I tested and I also faced the problem in this branch. (It is same problem with above @AhyoungRyu's comment.)
At first time, It was worked very well.
But when I rerun same paragraph, it was not worked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1833
Tested. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1833
Tested but i also see the same result @astroshim has.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1833: [ZEPPELIN-1880] Fix shell interpreter output st...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1833
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1833
Hi.
In my case it seems doesn`t work properly.. What am i missing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1833
@astroshim @Leemoonsoo @soralee If you don't mind, can someone help review this again? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1833
I rebased from master after #1922 and #1927 merged. Both are fixing the problem that I mentioned in [this comment](https://github.com/apache/zeppelin/pull/1833#issuecomment-270078954). Here is the screenshot.
@astroshim Thanks again for the fix!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1833
Thanks all you guys for testing it out!
Will merge if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1833
Seems the streaming output works only once right after I start Zeppelin (or restart shell intp). Let me dig into more. Thanks for the review @astroshim @Leemoonsoo!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1833
@astroshim @Leemoonsoo I guess the issue that I told in the above is not a matter of Shell intp itself. I found wired behaviour of current streaming output feature. This occurs in `master` branch.
If I use only Spark, it's streaming output works properly like below.
- Run only Spark (tried 3 times in a row)
```
(1 to 5).foreach{ i=>
Thread.sleep(500)
println("Hello " + i)
}
```
But if I use Spark -> **Shell** -> Spark intp, then Spark's streaming output also doesn't work.
- Run Spark -> Shell -> Spark
@Leemoonsoo Are there any suspicious points in this problem? The above issue is not in `0.6.2`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1833
@soralee Thanks for testing it out. Right I think the rerunning issue is due to that I mentioned in [this comment](https://github.com/apache/zeppelin/pull/1833#issuecomment-270078954).
@astroshim @Leemoonsoo BTW just to be making sure, did you build this branch including shell interpreter like `mvn clean package -DskipTests -pl 'shell, zeppelin-interpreter, zeppelin-server, zeppelin-zengine'` to test this patch? After build and restart Zeppelin, the result should be same with @soralee and me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1833
Tested and it works very well!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---