You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2024/03/12 03:11:13 UTC

[PR] [CELEBORN-1324][MINOR] Remove unused PrometheusSink class [incubator-celeborn]

turboFei opened a new pull request, #2381:
URL: https://github.com/apache/incubator-celeborn/pull/2381

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   PrometheusSink is not used.
   
   ### Why are the changes needed?
   
   Close CELEBORN-1324
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   Not needed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1324][MINOR] Remove unused PrometheusSink class [incubator-celeborn]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2381:
URL: https://github.com/apache/incubator-celeborn/pull/2381#issuecomment-1990023547

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2381?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 48.88%. Comparing base [(`b3eed34`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/b3eed34b57feeee97fa5c05d8e0f104a36c97488?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9d837cf`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2381?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 6 commits behind head on main.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #2381      +/-   ##
   ==========================================
   + Coverage   48.72%   48.88%   +0.16%     
   ==========================================
     Files         209      208       -1     
     Lines       13014    13017       +3     
     Branches     1121     1121              
   ==========================================
   + Hits         6340     6362      +22     
   + Misses       6263     6247      -16     
   + Partials      411      408       -3     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2381?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1324][MINOR] Remove unused PrometheusSink class [incubator-celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2381:
URL: https://github.com/apache/incubator-celeborn/pull/2381#issuecomment-1990755026

   LGTM. Merging to main(v0.5.0) and branch-0.4(v0.4.1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1324][MINOR] Remove unused PrometheusSink class [incubator-celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #2381: [CELEBORN-1324][MINOR] Remove unused PrometheusSink class
URL: https://github.com/apache/incubator-celeborn/pull/2381


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org