You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ode.apache.org by mr...@apache.org on 2008/06/10 20:48:40 UTC
svn commit: r666271 -
/ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
Author: mriou
Date: Tue Jun 10 11:48:40 2008
New Revision: 666271
URL: http://svn.apache.org/viewvc?rev=666271&view=rev
Log:
That was a little too nice.
Modified:
ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
Modified: ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
URL: http://svn.apache.org/viewvc/ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java?rev=666271&r1=666270&r2=666271&view=diff
==============================================================================
--- ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java (original)
+++ ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java Tue Jun 10 11:48:40 2008
@@ -101,10 +101,18 @@
private static class SchemaErrorHandler implements DOMErrorHandler {
public boolean handleError(DOMError error) {
- __log.warn("Schema error", ((Exception)error.getRelatedException()));
- __log.warn(error.getLocation().getUri() + ":" + error.getLocation().getLineNumber());
- __log.warn(error.getRelatedData());
- __log.warn(error.getRelatedException());
+ boolean isWarning = (error.getSeverity() == DOMError.SEVERITY_WARNING);
+ if (isWarning) {
+ __log.warn("Schema error", ((Exception)error.getRelatedException()));
+ __log.warn(error.getLocation().getUri() + ":" + error.getLocation().getLineNumber());
+ __log.warn(error.getRelatedData());
+ __log.warn(error.getRelatedException());
+ } else {
+ __log.error("Schema error", ((Exception)error.getRelatedException()));
+ __log.error(error.getLocation().getUri() + ":" + error.getLocation().getLineNumber());
+ __log.error(error.getRelatedData());
+ __log.error(error.getRelatedException());
+ }
return false;
}
}
Re: svn commit: r666271 - /ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
Posted by Matthieu Riou <ma...@offthelip.org>.
Heh. Yes it should.
On Tue, Jun 10, 2008 at 12:23 PM, Alex Boisvert <bo...@intalio.com>
wrote:
> Shouldn't the return be (isWarning)? since we don't want to stop
> processing
> for warnings...
>
> alex
>
> On Tue, Jun 10, 2008 at 11:48 AM, <mr...@apache.org> wrote:
>
> > Author: mriou
> > Date: Tue Jun 10 11:48:40 2008
> > New Revision: 666271
> >
> > URL: http://svn.apache.org/viewvc?rev=666271&view=rev
> > Log:
> > That was a little too nice.
> >
> > Modified:
> >
> >
> ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
> >
> > Modified:
> >
> ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
> > URL:
> >
> http://svn.apache.org/viewvc/ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java?rev=666271&r1=666270&r2=666271&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
> > (original)
> > +++
> >
> ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
> > Tue Jun 10 11:48:40 2008
> > @@ -101,10 +101,18 @@
> >
> > private static class SchemaErrorHandler implements DOMErrorHandler {
> > public boolean handleError(DOMError error) {
> > - __log.warn("Schema error",
> > ((Exception)error.getRelatedException()));
> > - __log.warn(error.getLocation().getUri() + ":" +
> > error.getLocation().getLineNumber());
> > - __log.warn(error.getRelatedData());
> > - __log.warn(error.getRelatedException());
> > + boolean isWarning = (error.getSeverity() ==
> > DOMError.SEVERITY_WARNING);
> > + if (isWarning) {
> > + __log.warn("Schema error",
> > ((Exception)error.getRelatedException()));
> > + __log.warn(error.getLocation().getUri() + ":" +
> > error.getLocation().getLineNumber());
> > + __log.warn(error.getRelatedData());
> > + __log.warn(error.getRelatedException());
> > + } else {
> > + __log.error("Schema error",
> > ((Exception)error.getRelatedException()));
> > + __log.error(error.getLocation().getUri() + ":" +
> > error.getLocation().getLineNumber());
> > + __log.error(error.getRelatedData());
> > + __log.error(error.getRelatedException());
> > + }
> > return false;
> > }
> > }
> >
> >
> >
>
Re: svn commit: r666271 - /ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
Posted by Alex Boisvert <bo...@intalio.com>.
Shouldn't the return be (isWarning)? since we don't want to stop processing
for warnings...
alex
On Tue, Jun 10, 2008 at 11:48 AM, <mr...@apache.org> wrote:
> Author: mriou
> Date: Tue Jun 10 11:48:40 2008
> New Revision: 666271
>
> URL: http://svn.apache.org/viewvc?rev=666271&view=rev
> Log:
> That was a little too nice.
>
> Modified:
>
> ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
>
> Modified:
> ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
> URL:
> http://svn.apache.org/viewvc/ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java?rev=666271&r1=666270&r2=666271&view=diff
>
> ==============================================================================
> ---
> ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
> (original)
> +++
> ode/trunk/utils/src/main/java/org/apache/ode/utils/xsd/SchemaModelImpl.java
> Tue Jun 10 11:48:40 2008
> @@ -101,10 +101,18 @@
>
> private static class SchemaErrorHandler implements DOMErrorHandler {
> public boolean handleError(DOMError error) {
> - __log.warn("Schema error",
> ((Exception)error.getRelatedException()));
> - __log.warn(error.getLocation().getUri() + ":" +
> error.getLocation().getLineNumber());
> - __log.warn(error.getRelatedData());
> - __log.warn(error.getRelatedException());
> + boolean isWarning = (error.getSeverity() ==
> DOMError.SEVERITY_WARNING);
> + if (isWarning) {
> + __log.warn("Schema error",
> ((Exception)error.getRelatedException()));
> + __log.warn(error.getLocation().getUri() + ":" +
> error.getLocation().getLineNumber());
> + __log.warn(error.getRelatedData());
> + __log.warn(error.getRelatedException());
> + } else {
> + __log.error("Schema error",
> ((Exception)error.getRelatedException()));
> + __log.error(error.getLocation().getUri() + ":" +
> error.getLocation().getLineNumber());
> + __log.error(error.getRelatedData());
> + __log.error(error.getRelatedException());
> + }
> return false;
> }
> }
>
>
>