You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/09/24 15:30:02 UTC
[jira] [Commented] (PHOENIX-4786) Reduce log level to debug when
logging new aggregate row key found and added results for scan ordered
queries
[ https://issues.apache.org/jira/browse/PHOENIX-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625986#comment-16625986 ]
Hudson commented on PHOENIX-4786:
---------------------------------
FAILURE: Integrated in Jenkins build Phoenix-omid2 #89 (See [https://builds.apache.org/job/Phoenix-omid2/89/])
PHOENIX-4786 Reduce log level to debug when logging new aggregate row (rajeshbabu: rev a0ef6613dfde647ac9b680744b4628dd2423c33f)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
> Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries
> -------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4786
> URL: https://issues.apache.org/jira/browse/PHOENIX-4786
> Project: Phoenix
> Issue Type: Bug
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Priority: Major
> Fix For: 5.0.0, 4.15.0
>
> Attachments: PHOENIX-4786.patch, PHOENIX-4786_v2.patch
>
>
> Currently we are logging key value when the new aggregate row found for scan ordered queries which is info log. This is going to add lot of overhead to the queries because sometimes we may write almost all the rows into log.
> {noformat}
> results.add(keyValue);
> if (logger.isInfoEnabled()) {
> logger.info(LogUtil.addCustomAnnotations("Adding new aggregate row: "
> + keyValue
> + ",for current key "
> + Bytes.toStringBinary(currentKey.get(), currentKey.getOffset(),
> currentKey.getLength()) + ", aggregated values: "
> + Arrays.asList(rowAggregators), ScanUtil.getCustomAnnotations(scan)));
> }
> {noformat}
> {noformat}
> [root@ctr-e138-1518143905142-358323-01-000010 hbase]# grep "Adding new aggregate row: " hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-000010.log.* | wc -l
> 19082854
> {noformat}
> It's changed recently as part of PHOENIX-4742 so better to make it debug only.
> {noformat}
> - if (logger.isDebugEnabled()) {
> - logger.debug(LogUtil.addCustomAnnotations("Adding new aggregate row: "
> + if (logger.isInfoEnabled()) {
> + logger.info(LogUtil.addCustomAnnotations("Adding new aggregate row: "
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)