[GitHub] [flink] pnowojski commented on a change in pull request #8731: [FLINK-11878][runtime] Implement the runtime handling of BoundedOneInput and BoundedMultiInput

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #8731: [FLINK-11878][runtime] Implement the runtime handling of BoundedOneInput and BoundedMultiInput
URL: https://github.com/apache/flink/pull/8731#discussion_r293705490
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
 ##########
 @@ -143,7 +143,7 @@ protected void markCanceledOrStopped() {
 	 * Checks whether the source has been canceled or stopped.
 	 * @return True, if the source is canceled or stopped, false is not.
 	 */
-	protected boolean isCanceledOrStopped() {
+	public boolean isCanceledOrStopped() {
 
 Review comment:
   I don't think you should mark `endInput` if it was cancelled - that should happen only if it has stopped (the same code path when `advanceToEndOfEventTime()` is being called).
   
   And please add a test for that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services