[GitHub] [spark] WeichenXu123 commented on pull request #40097: [SPARK-42508][CONNECT][ML] Extract the common .ml classes to `mllib-common`

["WeichenXu123 (via GitHub)" <gi...@apache.org>]

WeichenXu123 commented on PR #40097:
URL: https://github.com/apache/spark/pull/40097#issuecomment-1441155203

   > This PR also copies following testsuites to spark-mllib-common:
   > 1, org.apache.spark.ml.attribute.*
   > 2, org.apache.spark.ml.linalg.* except:
   > 
   > test("JavaTypeInference with VectorUDT") in VectorUDTSuite due to cyclical dependency;
   > 3, org.apache.spark.ml.param.* except:
   > 
   > test("Filtering ParamMap") in ParamsSuite due to cyclical dependency;
   
   This is bad for code maintenance. Can we move these tests to a "ml-common-test" jar, and in ml-client / ml-server tests they both run tests in "ml-common-test" jar ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org