You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/27 20:54:16 UTC

[GitHub] [incubator-tvm] dpankratz commented on issue #5156: [Bugfix] Fixed rewrite_simplify to correctly cast integers known at compile time.

dpankratz commented on issue #5156: [Bugfix] Fixed rewrite_simplify to correctly cast integers known at compile time.
URL: https://github.com/apache/incubator-tvm/pull/5156#issuecomment-605310597
 
 
   > 
   > 
   > Perhaps it would be better to check the OOB directly in MakeConstScalar, so that we thrown an ValueError directly when the value goes out of bound
   
   I agree, that's likely better since the values are known anyway. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services