[GitHub] [spark] tdas commented on a change in pull request #28040: [SPARK-31278][SS] Fix StreamingQuery output rows metric

[GitBox <gi...@apache.org>]

tdas commented on a change in pull request #28040: [SPARK-31278][SS] Fix StreamingQuery output rows metric
URL: https://github.com/apache/spark/pull/28040#discussion_r398897735
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
 ##########
 @@ -143,7 +143,7 @@ trait ProgressReporter extends Logging {
   }
 
   /** Finalizes the query progress and adds it to list of recent status updates. */
-  protected def finishTrigger(hasNewData: Boolean): Unit = {
+  protected def finishTrigger(hasNewData: Boolean, hasExecuted: Boolean): Unit = {
 
 Review comment:
   Add scala docs to explain the difference between these two flags. This is pretty confusing, and easy mix up when passing the two booleans.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org