You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gilles Sadowski <gi...@harfang.homelinux.org> on 2012/03/04 03:35:43 UTC
[VOTE] Release Commons Math 3.0
Hello.
Please review the deliverables for Math 3.0.
Tag:
https://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_3_0_RC2/
Site:
http://people.apache.org/builds/commons/math/3.0/RC2/
Binaries:
https://repository.apache.org/content/repositories/orgapachecommons-050/org/apache/commons/commons-math3/3.0/
[ ] +1 Release it.
[ ] +0 Go ahead; I don't care.
[ ] -1 No, do not release it because ...
This vote will close in 72 hours (02:30 GMT 07/03/2012).
Thanks and best regards,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[CANCEL][VOTE] Release Commons Math 3.0
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
Vote cancelled.
Please refer to the new thread with subject:
"[VOTE] Release Commons Math 3.0 (RC2, take 2)"
On Sun, Mar 04, 2012 at 03:35:43AM +0100, Gilles Sadowski wrote:
> Hello.
>
> Please review the deliverables for Math 3.0.
>
> Tag:
> https://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_3_0_RC2/
>
> Site:
> http://people.apache.org/builds/commons/math/3.0/RC2/
>
> Binaries:
> https://repository.apache.org/content/repositories/orgapachecommons-050/org/apache/commons/commons-math3/3.0/
>
> [ ] +1 Release it.
> [ ] +0 Go ahead; I don't care.
> [ ] -1 No, do not release it because ...
>
> This vote will close in 72 hours (02:30 GMT 07/03/2012).
>
>
> Thanks and best regards,
> Gilles
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Math 3.0
Posted by Luc Maisonobe <Lu...@free.fr>.
Le 04/03/2012 16:10, Luc Maisonobe a écrit :
> Le 04/03/2012 15:30, Gilles Sadowski a écrit :
>> On Sun, Mar 04, 2012 at 08:55:09AM -0500, Gary Gregory wrote:
>>> The RAT report complains about a couple of Java files.
>>
>> Thanks for pointing this out (I had never looked at the RAT report...).
>>
>> These are the incriminated files:
>> ---CUT---
>> Unapproved licenses:
>>
>> src/test/R/KolmogorovSmirnovDistributionTestCases.R
>> src/test/java/org/apache/commons/math3/ode/sampling/StepNormalizerOutputTest.java
>> src/test/java/org/apache/commons/math3/ode/sampling/StepNormalizerOutputOverlapTest.java
>> src/test/java/org/apache/commons/math3/ode/sampling/StepNormalizerOutputTestBase.java
>> src/test/resources/org/apache/commons/math3/random/testData.txt
>> src/test/resources/org/apache/commons/math3/random/emptyFile.txt
>> src/test/resources/org/apache/commons/math3/linear/matrix2.csv
>> src/test/resources/org/apache/commons/math3/linear/matrix1.csv
>> src/test/resources/org/apache/commons/math3/stat/data/Lew.txt
>> src/test/resources/org/apache/commons/math3/stat/data/Michelso.txt
>> src/test/resources/org/apache/commons/math3/stat/data/NumAcc3.txt
>> src/test/resources/org/apache/commons/math3/stat/data/NumAcc1.txt
>> src/test/resources/org/apache/commons/math3/stat/data/Mavro.txt
>> src/test/resources/org/apache/commons/math3/stat/data/NumAcc2.txt
>> src/test/resources/org/apache/commons/math3/stat/data/Lottery.txt
>> src/test/resources/org/apache/commons/math3/stat/data/PiDigits.txt
>> src/test/resources/org/apache/commons/math3/stat/data/NumAcc4.txt
>> src/site/resources/style/project.css
>> siteMods/site.css
>> ---CUT---
>>
>> Is this a serious problem? [All (except the style sheet ones) files are in
>> the "test" source tree.]
>>
>> * Some Java files miss the license header.
>> * If I'm not mistaken, the problematic files in
>> src/test/resources/org/apache/commons/math3/stat/data/"
>> were copied from NIST (?). I'm not even sure that we could just stamp them
>> with the Apache license.
>> * CSS files for the Commons web site
>
> The data and css file are no problems.
> The Java files are a problem. I'll fix that in trunk so you can copy
> them to a new tag.
I have fixed the java files *in trunk* as of r1296822.
The remaining files with the missing headers are OK.
Luc
>
> Luc
>
>>
>>
>> Please advise,
>> Gilles
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Math 3.0
Posted by Luc Maisonobe <Lu...@free.fr>.
Le 04/03/2012 15:30, Gilles Sadowski a écrit :
> On Sun, Mar 04, 2012 at 08:55:09AM -0500, Gary Gregory wrote:
>> The RAT report complains about a couple of Java files.
>
> Thanks for pointing this out (I had never looked at the RAT report...).
>
> These are the incriminated files:
> ---CUT---
> Unapproved licenses:
>
> src/test/R/KolmogorovSmirnovDistributionTestCases.R
> src/test/java/org/apache/commons/math3/ode/sampling/StepNormalizerOutputTest.java
> src/test/java/org/apache/commons/math3/ode/sampling/StepNormalizerOutputOverlapTest.java
> src/test/java/org/apache/commons/math3/ode/sampling/StepNormalizerOutputTestBase.java
> src/test/resources/org/apache/commons/math3/random/testData.txt
> src/test/resources/org/apache/commons/math3/random/emptyFile.txt
> src/test/resources/org/apache/commons/math3/linear/matrix2.csv
> src/test/resources/org/apache/commons/math3/linear/matrix1.csv
> src/test/resources/org/apache/commons/math3/stat/data/Lew.txt
> src/test/resources/org/apache/commons/math3/stat/data/Michelso.txt
> src/test/resources/org/apache/commons/math3/stat/data/NumAcc3.txt
> src/test/resources/org/apache/commons/math3/stat/data/NumAcc1.txt
> src/test/resources/org/apache/commons/math3/stat/data/Mavro.txt
> src/test/resources/org/apache/commons/math3/stat/data/NumAcc2.txt
> src/test/resources/org/apache/commons/math3/stat/data/Lottery.txt
> src/test/resources/org/apache/commons/math3/stat/data/PiDigits.txt
> src/test/resources/org/apache/commons/math3/stat/data/NumAcc4.txt
> src/site/resources/style/project.css
> siteMods/site.css
> ---CUT---
>
> Is this a serious problem? [All (except the style sheet ones) files are in
> the "test" source tree.]
>
> * Some Java files miss the license header.
> * If I'm not mistaken, the problematic files in
> src/test/resources/org/apache/commons/math3/stat/data/"
> were copied from NIST (?). I'm not even sure that we could just stamp them
> with the Apache license.
> * CSS files for the Commons web site
The data and css file are no problems.
The Java files are a problem. I'll fix that in trunk so you can copy
them to a new tag.
Luc
>
>
> Please advise,
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Math 3.0
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
On Sun, Mar 04, 2012 at 08:55:09AM -0500, Gary Gregory wrote:
> The RAT report complains about a couple of Java files.
Thanks for pointing this out (I had never looked at the RAT report...).
These are the incriminated files:
---CUT---
Unapproved licenses:
src/test/R/KolmogorovSmirnovDistributionTestCases.R
src/test/java/org/apache/commons/math3/ode/sampling/StepNormalizerOutputTest.java
src/test/java/org/apache/commons/math3/ode/sampling/StepNormalizerOutputOverlapTest.java
src/test/java/org/apache/commons/math3/ode/sampling/StepNormalizerOutputTestBase.java
src/test/resources/org/apache/commons/math3/random/testData.txt
src/test/resources/org/apache/commons/math3/random/emptyFile.txt
src/test/resources/org/apache/commons/math3/linear/matrix2.csv
src/test/resources/org/apache/commons/math3/linear/matrix1.csv
src/test/resources/org/apache/commons/math3/stat/data/Lew.txt
src/test/resources/org/apache/commons/math3/stat/data/Michelso.txt
src/test/resources/org/apache/commons/math3/stat/data/NumAcc3.txt
src/test/resources/org/apache/commons/math3/stat/data/NumAcc1.txt
src/test/resources/org/apache/commons/math3/stat/data/Mavro.txt
src/test/resources/org/apache/commons/math3/stat/data/NumAcc2.txt
src/test/resources/org/apache/commons/math3/stat/data/Lottery.txt
src/test/resources/org/apache/commons/math3/stat/data/PiDigits.txt
src/test/resources/org/apache/commons/math3/stat/data/NumAcc4.txt
src/site/resources/style/project.css
siteMods/site.css
---CUT---
Is this a serious problem? [All (except the style sheet ones) files are in
the "test" source tree.]
* Some Java files miss the license header.
* If I'm not mistaken, the problematic files in
src/test/resources/org/apache/commons/math3/stat/data/"
were copied from NIST (?). I'm not even sure that we could just stamp them
with the Apache license.
* CSS files for the Commons web site
Please advise,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Math 3.0
Posted by Gary Gregory <ga...@gmail.com>.
The RAT report complains about a couple of Java files.
Gary
On Mar 3, 2012, at 21:36, Gilles Sadowski <gi...@harfang.homelinux.org> wrote:
> Hello.
>
> Please review the deliverables for Math 3.0.
>
> Tag:
> https://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_3_0_RC2/
>
> Site:
> http://people.apache.org/builds/commons/math/3.0/RC2/
>
> Binaries:
> https://repository.apache.org/content/repositories/orgapachecommons-050/org/apache/commons/commons-math3/3.0/
>
> [ ] +1 Release it.
> [ ] +0 Go ahead; I don't care.
> [ ] -1 No, do not release it because ...
>
> This vote will close in 72 hours (02:30 GMT 07/03/2012).
>
>
> Thanks and best regards,
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Math 3.0
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
Hi.
On Sun, Mar 04, 2012 at 11:25:00AM +0100, Luc Maisonobe wrote:
> Le 04/03/2012 03:35, Gilles Sadowski a écrit :
> > Hello.
> >
> > Please review the deliverables for Math 3.0.
> >
> > Tag:
> > https://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_3_0_RC2/
> >
> > Site:
> > http://people.apache.org/builds/commons/math/3.0/RC2/
> >
> > Binaries:
> > https://repository.apache.org/content/repositories/orgapachecommons-050/org/apache/commons/commons-math3/3.0/
> >
> > [ ] +1 Release it.
> > [ ] +0 Go ahead; I don't care.
>
> -0.
> There are a few minor glitches.
>
> - the binary distribution archives commons-math3-3.0-bin.tar.gz
> and commons-math3-3.0-bin.zip contain both 3.0 and 3.0-SNAPSHOT
> files (commons-math3-3.0.jar, commons-math3-3.0-SNAPSHOT-javadoc.jar,
> commons-math3-3.0-sources.jar, commons-math3-3.0-SNAPSHOT-sources.jar,
> commons-math3-3.0-javadoc.jar and
> commons-math3-3.0/commons-math3-3.0-SNAPSHOT.jar
I must have forgotten a "clean" in command stream.
> - there is one checkstyle warning about a wrong order in
> BaseAbstractUnivariateIntegrator: the protected iterations field is
> declared before several other fields which are now final in the RC
> (they are protected in the trunk, so I did not fixed this, it depends
> on whether another RC is done or not)
I hope that we can let this in.
> - The site at http://people.apache.org/builds/commons/math/3.0/RC2/
> seems to be missing many files (there is only one changes-report.html
> file and four subdirectories: apidocs, css, images and style)
I had the feeling that the directory was not quite right (but at the late
hour, it did not ring a bell...).
I forgot to run "mvn site" before "mvn site:stage-deploy".
> As what we release are sources and binary files are only a convenience,
> I don't know if this should be considered a blocker or not, hence the -0.
I've uploaded a new batch. The source tree was not changed, so I hope that
it is OK to refer to the same tag.
> Also note that Nexus automatically adds md5 and sha1 checksum to the asc
> signature files. These signatures on signatures are spurious and should
> be manually removed from Nexus staging area.
Also done.
> Anyway, this is a very good job, Gilles.
Thanks for your quick response.
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Math 3.0
Posted by Luc Maisonobe <Lu...@free.fr>.
Le 04/03/2012 03:35, Gilles Sadowski a écrit :
> Hello.
>
> Please review the deliverables for Math 3.0.
>
> Tag:
> https://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_3_0_RC2/
>
> Site:
> http://people.apache.org/builds/commons/math/3.0/RC2/
>
> Binaries:
> https://repository.apache.org/content/repositories/orgapachecommons-050/org/apache/commons/commons-math3/3.0/
>
> [ ] +1 Release it.
> [ ] +0 Go ahead; I don't care.
-0.
There are a few minor glitches.
- the binary distribution archives commons-math3-3.0-bin.tar.gz
and commons-math3-3.0-bin.zip contain both 3.0 and 3.0-SNAPSHOT
files (commons-math3-3.0.jar, commons-math3-3.0-SNAPSHOT-javadoc.jar,
commons-math3-3.0-sources.jar, commons-math3-3.0-SNAPSHOT-sources.jar,
commons-math3-3.0-javadoc.jar and
commons-math3-3.0/commons-math3-3.0-SNAPSHOT.jar
- there is one checkstyle warning about a wrong order in
BaseAbstractUnivariateIntegrator: the protected iterations field is
declared before several other fields which are now final in the RC
(they are protected in the trunk, so I did not fixed this, it depends
on whether another RC is done or not)
- The site at http://people.apache.org/builds/commons/math/3.0/RC2/
seems to be missing many files (there is only one changes-report.html
file and four subdirectories: apidocs, css, images and style)
As what we release are sources and binary files are only a convenience,
I don't know if this should be considered a blocker or not, hence the -0.
Also note that Nexus automatically adds md5 and sha1 checksum to the asc
signature files. These signatures on signatures are spurious and should
be manually removed from Nexus staging area.
Anyway, this is a very good job, Gilles.
Thanks a lot!
Luc
> [ ] -1 No, do not release it because ...
>
> This vote will close in 72 hours (02:30 GMT 07/03/2012).
>
>
> Thanks and best regards,
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Math 3.0
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
Hi.
> > [...]
> >> There is still an old artifact in the jar:
> >>
> >> templates/math-release-notes.vm
> >>
> >> which comes from
> >>
> >> src/main/resources/templates/math-release-notes.vm
> >>
> >> The actual release notes are now generated from
> >>
> >> src/changes/release-notes.vm
> >
> > Yes, I discovered that the hard way because
> >
> > $ mvn changes:annoucement-generate
> >
> > does not work as is, you need to explicitly indicate where to pick the
> > template...
>
> hmm this is strange, as the new location is configured in the
> commons-parent pom, and CM should inherit from there. I tried it locally
> and it worked without specifying the location.
Does it work with exactly the command above? Looking further into it, I
discovered that the configuration (in "commons-parent") is in a profile
named "release-notes". So this
$ mvn -Prelease-notes changes:annoucement-generate
works indeed.
> [...]
Regards,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Math 3.0
Posted by Thomas Neidhart <th...@gmail.com>.
On 03/04/2012 04:00 PM, Gilles Sadowski wrote:
> On Sun, Mar 04, 2012 at 03:10:17PM +0100, Thomas Neidhart wrote:
>> On 03/04/2012 03:35 AM, Gilles Sadowski wrote:
>>> Hello.
>>>
>>> Please review the deliverables for Math 3.0.
>>
>> There is still an old artifact in the jar:
>>
>> templates/math-release-notes.vm
>>
>> which comes from
>>
>> src/main/resources/templates/math-release-notes.vm
>>
>> The actual release notes are now generated from
>>
>> src/changes/release-notes.vm
>
> Yes, I discovered that the hard way because
>
> $ mvn changes:annoucement-generate
>
> does not work as is, you need to explicitly indicate where to pick the
> template...
hmm this is strange, as the new location is configured in the
commons-parent pom, and CM should inherit from there. I tried it locally
and it worked without specifying the location.
>> So the former file could be safely removed.
>
> Yes, but I'd rather not touch the src tree if we can help it.
> If we can't, I'll do it.
You can also specify an exclude in the pom.xml to prevent it being
included in the final jar, something like:
<build>
<resources>
<resource>
<directory>src/main/resources</directory>
<excludes>
<exclude>templates/*.vm</exclude>
</excludes>
</resource>
</resources>
</build>
Best,
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Math 3.0
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
On Sun, Mar 04, 2012 at 03:10:17PM +0100, Thomas Neidhart wrote:
> On 03/04/2012 03:35 AM, Gilles Sadowski wrote:
> > Hello.
> >
> > Please review the deliverables for Math 3.0.
>
> There is still an old artifact in the jar:
>
> templates/math-release-notes.vm
>
> which comes from
>
> src/main/resources/templates/math-release-notes.vm
>
> The actual release notes are now generated from
>
> src/changes/release-notes.vm
Yes, I discovered that the hard way because
$ mvn changes:annoucement-generate
does not work as is, you need to explicitly indicate where to pick the
template...
>
> So the former file could be safely removed.
Yes, but I'd rather not touch the src tree if we can help it.
If we can't, I'll do it.
Thanks,
Gilles
>
> Thanks for all the effort, great work Gilles!
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Math 3.0
Posted by Thomas Neidhart <th...@gmail.com>.
On 03/04/2012 03:35 AM, Gilles Sadowski wrote:
> Hello.
>
> Please review the deliverables for Math 3.0.
There is still an old artifact in the jar:
templates/math-release-notes.vm
which comes from
src/main/resources/templates/math-release-notes.vm
The actual release notes are now generated from
src/changes/release-notes.vm
So the former file could be safely removed.
Thanks for all the effort, great work Gilles!
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org