You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/13 19:05:47 UTC

[GitHub] yuxihu commented on a change in pull request #13043: Fix test failure due to hybridize call in test_gluon_rnn.test_layer_fill_shape

yuxihu commented on a change in pull request #13043: Fix test failure due to hybridize call in test_gluon_rnn.test_layer_fill_shape
URL: https://github.com/apache/incubator-mxnet/pull/13043#discussion_r233181470
 
 

 ##########
 File path: src/imperative/imperative.cc
 ##########
 @@ -494,9 +494,14 @@ std::vector<NDArray*> Imperative::Backward(
   bool prev_training = set_is_training(is_train);
 
 Review comment:
   Although the lines are unrelated to the bug we are trying to fix here, it looks like we need to reset those as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services