You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/12 12:07:27 UTC

[GitHub] [flink] dawidwys opened a new pull request, #19439: [FLINK-26977] Remove no longer valid tests in JobMasterStopWithSavepointITCase

dawidwys opened a new pull request, #19439:
URL: https://github.com/apache/flink/pull/19439

   
   ## What is the purpose of the change
   
   Tests in JobMasterStopWithSavepointITCase are no longer valid. In
   particular the way number of restarts is calculated is wrong. Moreover
   cases that were supposed to be tested in the class are already covered
   in SavepointITCase.
   
   
   ## Verifying this change
   
   This change removes invalid tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dmvk commented on pull request #19439: [FLINK-26977] Remove no longer valid tests in JobMasterStopWithSavepointITCase

Posted by GitBox <gi...@apache.org>.
dmvk commented on PR #19439:
URL: https://github.com/apache/flink/pull/19439#issuecomment-1097657238

   Maybe the first commit message should be renamed:
   
   `Fix SavepointITCase#testStopWithSavepointFailingAfterSnapshotCreation`
   
   In my understanding it doesn't really fix anything and just aligns the code path for both schedulers. Is that correct?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys closed pull request #19439: [FLINK-26977] Remove no longer valid tests in JobMasterStopWithSavepointITCase

Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #19439: [FLINK-26977] Remove no longer valid tests in JobMasterStopWithSavepointITCase
URL: https://github.com/apache/flink/pull/19439


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #19439: [FLINK-26977] Remove no longer valid tests in JobMasterStopWithSavepointITCase

Posted by GitBox <gi...@apache.org>.
dawidwys commented on PR #19439:
URL: https://github.com/apache/flink/pull/19439#issuecomment-1097626371

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19439: [FLINK-26977] Remove no longer valid tests in JobMasterStopWithSavepointITCase

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19439:
URL: https://github.com/apache/flink/pull/19439#issuecomment-1096646782

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "074f6c3279b9d355e3bd11e96f313f232109f69c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "074f6c3279b9d355e3bd11e96f313f232109f69c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 074f6c3279b9d355e3bd11e96f313f232109f69c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org