You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/18 10:57:59 UTC

[GitHub] [airflow] AlexandrKhabarov commented on a change in pull request #7446: [AIRFLOW-6474] list_dag_runs cli command should allow exec_date between start/end range and print start/end times

AlexandrKhabarov commented on a change in pull request #7446: [AIRFLOW-6474] list_dag_runs cli command should allow exec_date between start/end range and print start/end times
URL: https://github.com/apache/airflow/pull/7446#discussion_r380600533
 
 

 ##########
 File path: airflow/cli/commands/dag_command.py
 ##########
 @@ -300,15 +300,17 @@ def dag_list_dag_runs(args, dag=None):
 
     dagbag = DagBag()
 
-    if args.dag_id not in dagbag.dags:
+    if args.dag_id is not None and args.dag_id not in dagbag.dags:
 
 Review comment:
   No, dag_id is optional parameter in this request. It is requirement of this task. See third point of the task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services