You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Jayson Minard (JIRA)" <ji...@apache.org> on 2009/01/09 11:48:59 UTC

[jira] Created: (SOLR-950) Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99

Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99
---------------------------------------------------------------------------------------------------

                 Key: SOLR-950
                 URL: https://issues.apache.org/jira/browse/SOLR-950
             Project: Solr
          Issue Type: Bug
          Components: search
    Affects Versions: 1.4
            Reporter: Jayson Minard
            Priority: Critical


When issuing a distributed request, the aggregator node caused an exception due to the following code at line 99 in FacetComponent.java

{code}
 if (refList == null | refList.size()==0) continue;
{code}

(!) note the single pipe for a bitwise OR rather than boolean OR

Change code to:

{code}
if (refList == null || refList.size() == 0) continue;
{code}



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-950) Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662521#action_12662521 ] 

Shalin Shekhar Mangar commented on SOLR-950:
--------------------------------------------

You are right Yonik. This was introduced after 1.3 was released. I'll update the changelog.

> Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-950
>                 URL: https://issues.apache.org/jira/browse/SOLR-950
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Jayson Minard
>            Assignee: Shalin Shekhar Mangar
>            Priority: Critical
>             Fix For: 1.4
>
>
> When issuing a distributed request, the aggregator node caused an exception due to the following code at line 99 in FacetComponent.java
> {code}
>  if (refList == null | refList.size()==0) continue;
> {code}
> (!) note the single pipe for a bitwise OR rather than boolean OR
> Change code to:
> {code}
> if (refList == null || refList.size() == 0) continue;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-950) Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99

Posted by "Jayson Minard (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jayson Minard updated SOLR-950:
-------------------------------

    Affects Version/s:     (was: 1.4)
                       1.3.1

> Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-950
>                 URL: https://issues.apache.org/jira/browse/SOLR-950
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3.1
>            Reporter: Jayson Minard
>            Priority: Critical
>             Fix For: 1.4
>
>
> When issuing a distributed request, the aggregator node caused an exception due to the following code at line 99 in FacetComponent.java
> {code}
>  if (refList == null | refList.size()==0) continue;
> {code}
> (!) note the single pipe for a bitwise OR rather than boolean OR
> Change code to:
> {code}
> if (refList == null || refList.size() == 0) continue;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-950) Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-950:
---------------------------------------

    Affects Version/s:     (was: 1.3.1)
                       1.3

> Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-950
>                 URL: https://issues.apache.org/jira/browse/SOLR-950
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Jayson Minard
>            Assignee: Shalin Shekhar Mangar
>            Priority: Critical
>             Fix For: 1.4
>
>
> When issuing a distributed request, the aggregator node caused an exception due to the following code at line 99 in FacetComponent.java
> {code}
>  if (refList == null | refList.size()==0) continue;
> {code}
> (!) note the single pipe for a bitwise OR rather than boolean OR
> Change code to:
> {code}
> if (refList == null || refList.size() == 0) continue;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SOLR-950) Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll closed SOLR-950.
--------------------------------


> Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-950
>                 URL: https://issues.apache.org/jira/browse/SOLR-950
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Jayson Minard
>            Assignee: Shalin Shekhar Mangar
>            Priority: Critical
>             Fix For: 1.4
>
>
> When issuing a distributed request, the aggregator node caused an exception due to the following code at line 99 in FacetComponent.java
> {code}
>  if (refList == null | refList.size()==0) continue;
> {code}
> (!) note the single pipe for a bitwise OR rather than boolean OR
> Change code to:
> {code}
> if (refList == null || refList.size() == 0) continue;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-950) Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-950.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4
         Assignee: Shalin Shekhar Mangar

Committed revision 733005.

Thanks Jayson!

> Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-950
>                 URL: https://issues.apache.org/jira/browse/SOLR-950
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3.1
>            Reporter: Jayson Minard
>            Assignee: Shalin Shekhar Mangar
>            Priority: Critical
>             Fix For: 1.4
>
>
> When issuing a distributed request, the aggregator node caused an exception due to the following code at line 99 in FacetComponent.java
> {code}
>  if (refList == null | refList.size()==0) continue;
> {code}
> (!) note the single pipe for a bitwise OR rather than boolean OR
> Change code to:
> {code}
> if (refList == null || refList.size() == 0) continue;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-950) Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99

Posted by "Jayson Minard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662350#action_12662350 ] 

Jayson Minard commented on SOLR-950:
------------------------------------

Shalin, thanks for committing the fix.

> Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-950
>                 URL: https://issues.apache.org/jira/browse/SOLR-950
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Jayson Minard
>            Assignee: Shalin Shekhar Mangar
>            Priority: Critical
>             Fix For: 1.4
>
>
> When issuing a distributed request, the aggregator node caused an exception due to the following code at line 99 in FacetComponent.java
> {code}
>  if (refList == null | refList.size()==0) continue;
> {code}
> (!) note the single pipe for a bitwise OR rather than boolean OR
> Change code to:
> {code}
> if (refList == null || refList.size() == 0) continue;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-950) Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662520#action_12662520 ] 

Yonik Seeley commented on SOLR-950:
-----------------------------------

I believe this bug was in unreleased code only (probably introduced through my changes to support multi-select faceting)?
That should somehow be made clear in CHANGES.txt so people don't think this was a 1.3 bug.

> Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-950
>                 URL: https://issues.apache.org/jira/browse/SOLR-950
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Jayson Minard
>            Assignee: Shalin Shekhar Mangar
>            Priority: Critical
>             Fix For: 1.4
>
>
> When issuing a distributed request, the aggregator node caused an exception due to the following code at line 99 in FacetComponent.java
> {code}
>  if (refList == null | refList.size()==0) continue;
> {code}
> (!) note the single pipe for a bitwise OR rather than boolean OR
> Change code to:
> {code}
> if (refList == null || refList.size() == 0) continue;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.