You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/18 18:10:20 UTC

[jira] [Commented] (KAFKA-3855) Guard race conditions in TopologyBuilder

    [ https://issues.apache.org/jira/browse/KAFKA-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382744#comment-15382744 ] 

ASF GitHub Bot commented on KAFKA-3855:
---------------------------------------

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/1633

    KAFKA-3855: Guard race conditions in TopologyBuilder

    Mark all public `TopologyBuilder` methods as synchronized as they can modify data-structures and these methods could be called from multiple threads

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka kafka-3855

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1633
    
----
commit 5178325457e09eb65a042cea3339cbb0c860beb1
Author: Damian Guy <da...@gmail.com>
Date:   2016-07-18T16:55:48Z

    mark all public TopologyBuilder methods as synchronized as they can modify data-structures and these methods could be called from multiple threads

----


> Guard race conditions in TopologyBuilder
> ----------------------------------------
>
>                 Key: KAFKA-3855
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3855
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Damian Guy
>              Labels: architecture
>
> The user specified {{TopologyBuilder}} is shared among all stream threads to build the processor topology instance, one for each thread. It public functions that can be accessed by the threads is not synchronized, and we need to double check if it could cause race conditions, and if yes guard against these concurrent access.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)