[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #17: [WIP] Pekko migration

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #17:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/17#discussion_r1093741899


##########
build.sbt:
##########
@@ -44,7 +45,7 @@ addCommandAlias("verifyCodeStyle", "headerCheck; verifyCodeFmt")
 addCommandAlias("verifyDocs", ";+doc ;unidoc ;docs/paradoxBrowse")
 
 val commonSettings = Def.settings(
-  organization := "com.typesafe.akka",
+  organization := "org.apache.pekko",
   organizationName := "Lightbend Inc.",

Review Comment:
   can you fix organizationName and organizationHomepage? same values as build.sbt in `incubator-pekko`
   
   leave the doc.akka.io urls as is for now - we can back to those when we start publishing the docs for other non-core pekko modules



##########
build.sbt:
##########
@@ -31,7 +31,8 @@ val confluentLibsExclusionRules = Seq(
 
 ThisBuild / resolvers ++= Seq(
   // for Jupiter interface (JUnit 5)
-  Resolver.jcenterRepo)
+  Resolver.jcenterRepo,
+  "Apache Snapshot Repo".at("https://repository.apache.org/content/groups/snapshots/"))

Review Comment:
   `"Apache Snapshot Repo" at "https://repository.apache.org/content/groups/snapshots/"`
   
   should work - reads slightly better
   
   



##########
build.sbt:
##########
@@ -231,15 +232,16 @@ lazy val tests = project
       "org.hamcrest" % "hamcrest-library" % "2.2" % Test,
       "org.hamcrest" % "hamcrest" % "2.2" % Test,
       "net.aichler" % "jupiter-interface" % JupiterKeys.jupiterVersion.value % Test,
-      "com.typesafe.akka" %% "akka-slf4j" % akkaVersion % Test,
+      "org.apache.pekko" %% "pekko-slf4j" % pekkoVersion % Test,
       "ch.qos.logback" % "logback-classic" % "1.2.11" % Test,
       "org.slf4j" % "log4j-over-slf4j" % slf4jVersion % Test,
       // Schema registry uses Glassfish which uses java.util.logging
       "org.slf4j" % "jul-to-slf4j" % slf4jVersion % Test,
       "org.mockito" % "mockito-core" % "4.6.1" % Test,
       "com.thesamet.scalapb" %% "scalapb-runtime" % "0.10.11" % Test),
     resolvers ++= Seq(
-      "Confluent Maven Repo".at("https://packages.confluent.io/maven/")),
+      "Confluent Maven Repo".at("https://packages.confluent.io/maven/"),
+      "Apache Snapshot Repo".at("https://repository.apache.org/content/groups/snapshots/")),

Review Comment:
   same issue as in resolvers above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org