You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/04/13 00:59:29 UTC
Review Request 66594: [ATLAS-2558]: Reevaluate propagated tags based
on blocked classifications in relationship edge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66594/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2588
https://issues.apache.org/jira/browse/ATLAS-2588
Repository: atlas
Description
-------
ATLAS-2552 provides capability to block/unblock classifications from propagating through the relationship edge. Propagation of tags needs to be reevaluated based on the entries of blocked classifications list.
When a classification is added to the blocked classifications list it should not propagate to any downstream entities.
When a classification is removed from the blocked classifications list, it should propagate to previously restricted entities.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ae22e7ab
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 7b2806e8
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 2b6863af
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 2d8b1530
repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 8828a87a
repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 3e3ee118
Diff: https://reviews.apache.org/r/66594/diff/1/
Testing
-------
Precommit in progress.
Thanks,
Sarath Subramanian
Re: Review Request 66594: [ATLAS-2558]: Reevaluate propagated tags
based on blocked classifications in relationship edge
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66594/#review201182
-----------------------------------------------------------
Ship it!
- Madhan Neethiraj
On April 16, 2018, 5:54 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66594/
> -----------------------------------------------------------
>
> (Updated April 16, 2018, 5:54 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2588
> https://issues.apache.org/jira/browse/ATLAS-2588
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-2552 provides capability to block/unblock classifications from propagating through the relationship edge. Propagation of tags needs to be reevaluated based on the entries of blocked classifications list.
>
> * When a classification is added to the blocked classifications list it should not propagate to any downstream entities.
> * When a classification is removed from the blocked classifications list, it should propagate to previously restricted entities.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ae22e7ab
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java cc59c36e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 2b6863af
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 2d8b1530
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java f8d967e6
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 8828a87a
> repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 3e3ee118
>
>
> Diff: https://reviews.apache.org/r/66594/diff/3/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/261/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66594: [ATLAS-2558]: Reevaluate propagated tags
based on blocked classifications in relationship edge
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66594/
-----------------------------------------------------------
(Updated April 15, 2018, 10:54 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Changes
-------
Updated logic to update tag propagation on relationship
Bugs: ATLAS-2588
https://issues.apache.org/jira/browse/ATLAS-2588
Repository: atlas
Description
-------
ATLAS-2552 provides capability to block/unblock classifications from propagating through the relationship edge. Propagation of tags needs to be reevaluated based on the entries of blocked classifications list.
* When a classification is added to the blocked classifications list it should not propagate to any downstream entities.
* When a classification is removed from the blocked classifications list, it should propagate to previously restricted entities.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ae22e7ab
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java cc59c36e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 2b6863af
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 2d8b1530
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java f8d967e6
repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 8828a87a
repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 3e3ee118
Diff: https://reviews.apache.org/r/66594/diff/3/
Changes: https://reviews.apache.org/r/66594/diff/2-3/
Testing
-------
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/261/console
Thanks,
Sarath Subramanian
Re: Review Request 66594: [ATLAS-2558]: Reevaluate propagated tags
based on blocked classifications in relationship edge
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66594/
-----------------------------------------------------------
(Updated April 13, 2018, 4:22 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2588
https://issues.apache.org/jira/browse/ATLAS-2588
Repository: atlas
Description
-------
ATLAS-2552 provides capability to block/unblock classifications from propagating through the relationship edge. Propagation of tags needs to be reevaluated based on the entries of blocked classifications list.
* When a classification is added to the blocked classifications list it should not propagate to any downstream entities.
* When a classification is removed from the blocked classifications list, it should propagate to previously restricted entities.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ae22e7ab
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 7b2806e8
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 2b6863af
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 2d8b1530
repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 8828a87a
repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 3e3ee118
Diff: https://reviews.apache.org/r/66594/diff/2/
Changes: https://reviews.apache.org/r/66594/diff/1-2/
Testing
-------
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/261/console
Thanks,
Sarath Subramanian