You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Alex Harui <ah...@adobe.com> on 2013/11/22 21:46:44 UTC
[FlexJS] JS Linting
I'm finishing up build scripts for the flex-asjs repo.
Should we/can we put linting into the build? I tried running JSHint from
the command-line by feeding it a ‹config option, but we get tons of
"Missing "use strict" statement" errors apparently because JSHint says
that if you are going to use the strict-mode checking you need to have the
'use strict" directive at the top of the file.
I turned off strict mode and still got some 81 errors.
Thoughts?
-Alex
Re: [FlexJS] JS Linting
Posted by Alex Harui <ah...@adobe.com>.
For sure we should use it, the question is whether it should fail the
build if we get lint errors, and I'm not sure how to get it to use strict
mode from a script.
On 11/22/13 1:02 PM, "Peter Ent" <pe...@adobe.com> wrote:
>I recall the Erik recommended using it. I'll have to get a copy and see
>why types of things it is complaining about. My instinct is to suggest
>using it, but having experienced gjslint, I'm a little wary of over doing
>it.
>
>--peter
>
>On 11/22/13 3:46 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
>>I'm finishing up build scripts for the flex-asjs repo.
>>
>>Should we/can we put linting into the build? I tried running JSHint from
>>the command-line by feeding it a ‹config option, but we get tons of
>>"Missing "use strict" statement" errors apparently because JSHint says
>>that if you are going to use the strict-mode checking you need to have
>>the
>>'use strict" directive at the top of the file.
>>
>>I turned off strict mode and still got some 81 errors.
>>
>>Thoughts?
>>
>>-Alex
>>
>
Re: [FlexJS] JS Linting
Posted by Peter Ent <pe...@adobe.com>.
I recall the Erik recommended using it. I'll have to get a copy and see
why types of things it is complaining about. My instinct is to suggest
using it, but having experienced gjslint, I'm a little wary of over doing
it.
--peter
On 11/22/13 3:46 PM, "Alex Harui" <ah...@adobe.com> wrote:
>I'm finishing up build scripts for the flex-asjs repo.
>
>Should we/can we put linting into the build? I tried running JSHint from
>the command-line by feeding it a ‹config option, but we get tons of
>"Missing "use strict" statement" errors apparently because JSHint says
>that if you are going to use the strict-mode checking you need to have the
>'use strict" directive at the top of the file.
>
>I turned off strict mode and still got some 81 errors.
>
>Thoughts?
>
>-Alex
>