You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2012/10/07 08:21:02 UTC
[jira] [Created] (BOOKKEEPER-423) Unify hub tests around
HedwigRegionTestBase
Stu Hood created BOOKKEEPER-423:
-----------------------------------
Summary: Unify hub tests around HedwigRegionTestBase
Key: BOOKKEEPER-423
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-423
Project: Bookkeeper
Issue Type: Improvement
Components: hedwig-server
Reporter: Stu Hood
Assignee: Stu Hood
HedwigRegionTestBase and HedwigHubTestBase duplicate one-another to a large degree (since the latter is the N=1 case of the former.)
Unifying these base classes would be DRYer, and would mean there would be a clear base to build test simplifications on top of.
Additionally, it would be good to be test with multiple regions in more places, and to start and stop hubs and regions within the same test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-423) Unify hub tests around
HedwigRegionTestBase
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471838#comment-13471838 ]
Flavio Junqueira commented on BOOKKEEPER-423:
---------------------------------------------
stu, would you mind putting this one on the review board?
> Unify hub tests around HedwigRegionTestBase
> -------------------------------------------
>
> Key: BOOKKEEPER-423
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-423
> Project: Bookkeeper
> Issue Type: Improvement
> Components: hedwig-server
> Reporter: Stu Hood
> Assignee: Stu Hood
> Attachments: bk-423.diff
>
>
> HedwigRegionTestBase and HedwigHubTestBase duplicate one-another to a large degree (since the latter is the N=1 case of the former.)
> Unifying these base classes would be DRYer, and would mean there would be a clear base to build test simplifications on top of.
> Additionally, it would be good to be test with multiple regions in more places, and to start and stop hubs and regions within the same test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-423) Unify hub tests around
HedwigRegionTestBase
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated BOOKKEEPER-423:
--------------------------------
Attachment: bk-423.diff
Attaching a batch that removes HedwigHubTestBase in favor of HedwigRegionTestBase.
Also (although no tests use it,) allows for starting and stopping individual hubs in regions. I'll follow up with additional tests to churn individual hubs in a multi-region environment.
> Unify hub tests around HedwigRegionTestBase
> -------------------------------------------
>
> Key: BOOKKEEPER-423
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-423
> Project: Bookkeeper
> Issue Type: Improvement
> Components: hedwig-server
> Reporter: Stu Hood
> Assignee: Stu Hood
> Attachments: bk-423.diff
>
>
> HedwigRegionTestBase and HedwigHubTestBase duplicate one-another to a large degree (since the latter is the N=1 case of the former.)
> Unifying these base classes would be DRYer, and would mean there would be a clear base to build test simplifications on top of.
> Additionally, it would be good to be test with multiple regions in more places, and to start and stop hubs and regions within the same test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-423) Unify hub tests around
HedwigRegionTestBase
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated BOOKKEEPER-423:
--------------------------------
Attachment: (was: bk-423.diff)
> Unify hub tests around HedwigRegionTestBase
> -------------------------------------------
>
> Key: BOOKKEEPER-423
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-423
> Project: Bookkeeper
> Issue Type: Improvement
> Components: hedwig-server
> Reporter: Stu Hood
> Assignee: Stu Hood
> Attachments: bk-423.diff
>
>
> HedwigRegionTestBase and HedwigHubTestBase duplicate one-another to a large degree (since the latter is the N=1 case of the former.)
> Unifying these base classes would be DRYer, and would mean there would be a clear base to build test simplifications on top of.
> Additionally, it would be good to be test with multiple regions in more places, and to start and stop hubs and regions within the same test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-423) Unify hub tests around
HedwigRegionTestBase
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated BOOKKEEPER-423:
--------------------------------
Attachment: bk-423.diff
> Unify hub tests around HedwigRegionTestBase
> -------------------------------------------
>
> Key: BOOKKEEPER-423
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-423
> Project: Bookkeeper
> Issue Type: Improvement
> Components: hedwig-server
> Reporter: Stu Hood
> Assignee: Stu Hood
> Attachments: bk-423.diff
>
>
> HedwigRegionTestBase and HedwigHubTestBase duplicate one-another to a large degree (since the latter is the N=1 case of the former.)
> Unifying these base classes would be DRYer, and would mean there would be a clear base to build test simplifications on top of.
> Additionally, it would be good to be test with multiple regions in more places, and to start and stop hubs and regions within the same test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-423) Unify hub tests around
HedwigRegionTestBase
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated BOOKKEEPER-423:
--------------------------------
Posted to reviewboard at https://reviews.apache.org/r/7479/
> Unify hub tests around HedwigRegionTestBase
> -------------------------------------------
>
> Key: BOOKKEEPER-423
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-423
> Project: Bookkeeper
> Issue Type: Improvement
> Components: hedwig-server
> Reporter: Stu Hood
> Assignee: Stu Hood
> Attachments: bk-423.diff
>
>
> HedwigRegionTestBase and HedwigHubTestBase duplicate one-another to a large degree (since the latter is the N=1 case of the former.)
> Unifying these base classes would be DRYer, and would mean there would be a clear base to build test simplifications on top of.
> Additionally, it would be good to be test with multiple regions in more places, and to start and stop hubs and regions within the same test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira