You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/05 16:58:59 UTC
[GitHub] [kafka] ableegoldman opened a new pull request #8815: HOTFIX: fix validity check in sticky assignor tests
ableegoldman opened a new pull request #8815:
URL: https://github.com/apache/kafka/pull/8815
Not sure what happened here, but there's a commented out line and incorrect indentation that checkstyle didn't catch. Not to mention the code itself is just generally questionable
Should be cherrypicked to 2.6, 2.5, and 2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #8815: HOTFIX: fix validity check in sticky assignor tests
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #8815:
URL: https://github.com/apache/kafka/pull/8815#issuecomment-639895860
also @guozhangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #8815: HOTFIX: fix validity check in sticky assignor tests
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #8815:
URL: https://github.com/apache/kafka/pull/8815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #8815: HOTFIX: fix validity check in sticky assignor tests
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #8815:
URL: https://github.com/apache/kafka/pull/8815#issuecomment-639631594
cc @edenhill
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8815: HOTFIX: fix validity check in sticky assignor tests
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8815:
URL: https://github.com/apache/kafka/pull/8815#issuecomment-640248563
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org