You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Neil Fordyce <ne...@hotmail.com> on 2016/09/05 18:05:44 UTC
Review Request 51630: SAMZA-1007: Pass job config from factory to
grouper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51630/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-1007
https://issues.apache.org/jira/browse/SAMZA-1007
Repository: samza
Description
-------
Supplying config to the grouper to allow broadcast streams to be configured when using GroupBySystemStreamPartitionFactory.
Diffs
-----
samza-core/src/main/java/org/apache/samza/container/grouper/stream/GroupBySystemStreamPartitionFactory.java 04a744492c0a4576c2812063ccf19c303c4d6ccf
samza-core/src/test/java/org/apache/samza/container/grouper/stream/TestGroupBySystemStreamPartition.java 1bd14a41bffa9c9b6c7bc3c5e890c1346124149a
Diff: https://reviews.apache.org/r/51630/diff/
Testing
-------
./gradlew clean build
Thanks,
Neil Fordyce
Re: Review Request 51630: SAMZA-1007: Pass job config from factory to
grouper
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51630/#review148404
-----------------------------------------------------------
Ship it!
Ship It!
- Navina Ramesh
On Sept. 6, 2016, 8:41 a.m., Neil Fordyce wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51630/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2016, 8:41 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-1007
> https://issues.apache.org/jira/browse/SAMZA-1007
>
>
> Repository: samza
>
>
> Description
> -------
>
> Supplying config to the grouper to allow broadcast streams to be configured when using GroupBySystemStreamPartitionFactory.
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/container/grouper/stream/GroupBySystemStreamPartition.java a8b41de5a8afa94d16727e6900f8556ce35c9f9c
> samza-core/src/main/java/org/apache/samza/container/grouper/stream/GroupBySystemStreamPartitionFactory.java 04a744492c0a4576c2812063ccf19c303c4d6ccf
> samza-core/src/test/java/org/apache/samza/container/grouper/stream/TestGroupBySystemStreamPartition.java 1bd14a41bffa9c9b6c7bc3c5e890c1346124149a
>
> Diff: https://reviews.apache.org/r/51630/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Neil Fordyce
>
>
Re: Review Request 51630: SAMZA-1007: Pass job config from factory to
grouper
Posted by Neil Fordyce <ne...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51630/
-----------------------------------------------------------
(Updated Sept. 6, 2016, 8:41 a.m.)
Review request for samza.
Bugs: SAMZA-1007
https://issues.apache.org/jira/browse/SAMZA-1007
Repository: samza
Description (updated)
-------
Supplying config to the grouper to allow broadcast streams to be configured when using GroupBySystemStreamPartitionFactory.
Diffs
-----
samza-core/src/main/java/org/apache/samza/container/grouper/stream/GroupBySystemStreamPartition.java a8b41de5a8afa94d16727e6900f8556ce35c9f9c
samza-core/src/main/java/org/apache/samza/container/grouper/stream/GroupBySystemStreamPartitionFactory.java 04a744492c0a4576c2812063ccf19c303c4d6ccf
samza-core/src/test/java/org/apache/samza/container/grouper/stream/TestGroupBySystemStreamPartition.java 1bd14a41bffa9c9b6c7bc3c5e890c1346124149a
Diff: https://reviews.apache.org/r/51630/diff/
Testing
-------
./gradlew clean build
Thanks,
Neil Fordyce
Re: Review Request 51630: SAMZA-1007: Pass job config from factory to
grouper
Posted by Neil Fordyce <ne...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51630/
-----------------------------------------------------------
(Updated Sept. 6, 2016, 8:39 a.m.)
Review request for samza.
Bugs: SAMZA-1007
https://issues.apache.org/jira/browse/SAMZA-1007
Repository: samza
Description (updated)
-------
Default constructor removed and modified test to use factory
Diffs (updated)
-----
samza-core/src/main/java/org/apache/samza/container/grouper/stream/GroupBySystemStreamPartition.java a8b41de5a8afa94d16727e6900f8556ce35c9f9c
samza-core/src/main/java/org/apache/samza/container/grouper/stream/GroupBySystemStreamPartitionFactory.java 04a744492c0a4576c2812063ccf19c303c4d6ccf
samza-core/src/test/java/org/apache/samza/container/grouper/stream/TestGroupBySystemStreamPartition.java 1bd14a41bffa9c9b6c7bc3c5e890c1346124149a
Diff: https://reviews.apache.org/r/51630/diff/
Testing
-------
./gradlew clean build
Thanks,
Neil Fordyce
Re: Review Request 51630: SAMZA-1007: Pass job config from factory to
grouper
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51630/#review147794
-----------------------------------------------------------
Fix it, then Ship it!
1 comment. otherwise, looks good. Thanks!
samza-core/src/main/java/org/apache/samza/container/grouper/stream/GroupBySystemStreamPartitionFactory.java (line 24)
<https://reviews.apache.org/r/51630/#comment215069>
Can you remove the default constructor in GroupBySystemStreamPartition? Just to avoid future incorrect usages. thanks!
- Navina Ramesh
On Sept. 5, 2016, 6:05 p.m., Neil Fordyce wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51630/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2016, 6:05 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-1007
> https://issues.apache.org/jira/browse/SAMZA-1007
>
>
> Repository: samza
>
>
> Description
> -------
>
> Supplying config to the grouper to allow broadcast streams to be configured when using GroupBySystemStreamPartitionFactory.
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/container/grouper/stream/GroupBySystemStreamPartitionFactory.java 04a744492c0a4576c2812063ccf19c303c4d6ccf
> samza-core/src/test/java/org/apache/samza/container/grouper/stream/TestGroupBySystemStreamPartition.java 1bd14a41bffa9c9b6c7bc3c5e890c1346124149a
>
> Diff: https://reviews.apache.org/r/51630/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Neil Fordyce
>
>