You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/25 19:35:16 UTC
[GitHub] codecov-io commented on issue #6933: Show charts and dashboards
based also on database permissions
codecov-io commented on issue #6933: Show charts and dashboards based also on database permissions
URL: https://github.com/apache/incubator-superset/pull/6933#issuecomment-467151142
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6933?src=pr&el=h1) Report
> Merging [#6933](https://codecov.io/gh/apache/incubator-superset/pull/6933?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9d22b2eca6cf823380adc96d2040a5c955edd8?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/6933?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6933 +/- ##
==========================================
+ Coverage 63.97% 63.99% +0.01%
==========================================
Files 422 422
Lines 20533 20539 +6
Branches 2230 2230
==========================================
+ Hits 13137 13143 +6
Misses 7264 7264
Partials 132 132
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6933?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6933/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <100%> (+0.03%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6933/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.61% <0%> (+0.05%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6933/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `81.8% <0%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6933?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6933?src=pr&el=footer). Last update [ea9d22b...c14fe44](https://codecov.io/gh/apache/incubator-superset/pull/6933?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org