[GitHub] [iceberg] zhongyujiang commented on a change in pull request #3910: Spark 3.2: Fix jmh Spark parquet benchmark

[GitBox <gi...@apache.org>]

zhongyujiang commented on a change in pull request #3910:
URL: https://github.com/apache/iceberg/pull/3910#discussion_r790154011



##########
File path: spark/v3.2/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetWritersFlatDataBenchmark.java
##########
@@ -85,7 +86,7 @@ public void setupBenchmark() throws IOException {
     dataFile.delete();
   }
 
-  @TearDown
+  @TearDown(Level.Invocation)

Review comment:
       Iteration and Invocation should have the same effect since BenchmarkMode here is SingleShotTime, but I think is should be Invocation since each Invocation will produce a file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org