[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #204: [YUNIKORN-439]Parse taskGroup info from pod annotation

[GitBox <gi...@apache.org>]

yangwwei commented on pull request #204:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/204#issuecomment-719281044


   hi @HuangTing-Yao 
   
   I just get #203 merged, could you please rebase this.
   Like offline discussed, could you please modify the type of `nodeSelector` to a map? that will be consistent with the `podSpec`
   
   ```
   @@ -61,7 +61,7 @@ type TaskGroup struct {
           Name         string                       `json:"name"`
           MinMember    int32                        `json:"minMember"`
           MinResource  map[string]resource.Quantity `json:"minResource"`
   -       NodeSelector metav1.LabelSelector         `json:"nodeSelector,omitempty"`
   +       NodeSelector map[string]string            `json:"nodeSelector,omitempty"`
           Tolerations  []v1.Toleration              `json:"tolerations,omitempty"`
    }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org