You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by chenerlu <gi...@git.apache.org> on 2017/04/27 11:29:41 UTC
[GitHub] incubator-carbondata pull request #866: [CARBONDATA-986] Update examples for...
GitHub user chenerlu opened a pull request:
https://github.com/apache/incubator-carbondata/pull/866
[CARBONDATA-986] Update examples for code style
Problem: code style relative problem
Solution: Update examples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenerlu/incubator-carbondata ModifyExample
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/866.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #866
----
commit 26507b7053555e6671a0394fa37cb02b499b4411
Author: chenerlu <ch...@huawei.com>
Date: 2017-04-27T11:20:09Z
update the examples
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #866: [CARBONDATA-986] Update examples for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/866
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #866: [CARBONDATA-986] Update examples for...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/866#discussion_r113791408
--- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/AlterTableExample.scala ---
@@ -55,17 +59,17 @@ object AlterTableExample {
spark.sql(
s"""
| CREATE TABLE carbon_table(
- | shortField short,
- | intField int,
- | bigintField long,
- | doubleField double,
- | stringField string,
- | timestampField timestamp,
- | decimalField decimal(18,2),
- | dateField date,
- | charField char(5),
- | floatField float,
- | complexData array<string>
+ | shortField short,
--- End diff --
if you are going to change this, please change all keyword to capital letter, like short to SHORT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #866: [CARBONDATA-986] Update examples for...
Posted by chenerlu <gi...@git.apache.org>.
Github user chenerlu commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/866#discussion_r113839591
--- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/AlterTableExample.scala ---
@@ -55,17 +59,17 @@ object AlterTableExample {
spark.sql(
s"""
| CREATE TABLE carbon_table(
- | shortField short,
- | intField int,
- | bigintField long,
- | doubleField double,
- | stringField string,
- | timestampField timestamp,
- | decimalField decimal(18,2),
- | dateField date,
- | charField char(5),
- | floatField float,
- | complexData array<string>
+ | shortField short,
--- End diff --
Done, have changed all keyword to capital letter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #866: [CARBONDATA-986] Update examples for code s...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/866
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1831/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #866: [CARBONDATA-986] Update examples for code s...
Posted by chenerlu <gi...@git.apache.org>.
Github user chenerlu commented on the issue:
https://github.com/apache/incubator-carbondata/pull/866
@jackylk @chenliang613 , pls help to review and merge this PR~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #866: [CARBONDATA-986] Update examples for code s...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/866
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #866: [CARBONDATA-986] Update examples for code s...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/866
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1833/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---