You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/06/03 12:01:55 UTC
Re: Review Request: CLOUDSTACK-2648 [Multiple_IP_Ranges] Reboot or
start/stop router vm deletes the ip alises created on VR in case of
multiple subnets
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11437/
-----------------------------------------------------------
(Updated June 3, 2013, 10:01 a.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Description
-------
[Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises created on VR in case of multiple subnets
https://issues.apache.org/jira/browse/CLOUDSTACK-2648
This addresses bug Cloudstack-2648.
Diffs (updated)
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 214e292
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java b969be2
Diff: https://reviews.apache.org/r/11437/diff/
Testing
-------
tested on master.
Thanks,
bharat kumar
Re: Review Request: CLOUDSTACK-2648 [Multiple_IP_Ranges] Reboot or
start/stop router vm deletes the ip alises created on VR in case of
multiple subnets
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11437/#review21311
-----------------------------------------------------------
Ship it!
Ship It!
- Koushik Das
On June 3, 2013, 10:10 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11437/
> -----------------------------------------------------------
>
> (Updated June 3, 2013, 10:10 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> [Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises created on VR in case of multiple subnets
> https://issues.apache.org/jira/browse/CLOUDSTACK-2648
>
>
> This addresses bug Cloudstack-2648.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 8b996d1
> patches/systemvm/debian/config/root/deleteIpAlias.sh 865ff3b
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5f99a15
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java a2cceb1
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037
>
> Diff: https://reviews.apache.org/r/11437/diff/
>
>
> Testing
> -------
>
> tested on master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: CLOUDSTACK-2648 [Multiple_IP_Ranges] Reboot or
start/stop router vm deletes the ip alises created on VR in case of
multiple subnets
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11437/#review21318
-----------------------------------------------------------
Commit 48913679e80e50228b1bd4b3d17fe5245461626a in branch refs/heads/master from Abhinandan Prateek <ap...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4891367 ]
CLOUDSTACK-2648 [Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises created on VR in case of multiple subnets
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On June 3, 2013, 10:10 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11437/
> -----------------------------------------------------------
>
> (Updated June 3, 2013, 10:10 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> [Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises created on VR in case of multiple subnets
> https://issues.apache.org/jira/browse/CLOUDSTACK-2648
>
>
> This addresses bug Cloudstack-2648.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 8b996d1
> patches/systemvm/debian/config/root/deleteIpAlias.sh 865ff3b
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5f99a15
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java a2cceb1
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037
>
> Diff: https://reviews.apache.org/r/11437/diff/
>
>
> Testing
> -------
>
> tested on master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: CLOUDSTACK-2648 [Multiple_IP_Ranges] Reboot or
start/stop router vm deletes the ip alises created on VR in case of
multiple subnets
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11437/
-----------------------------------------------------------
(Updated June 3, 2013, 10:10 a.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Changes
-------
Incorporated the review comments and updated the diff.
Description
-------
[Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises created on VR in case of multiple subnets
https://issues.apache.org/jira/browse/CLOUDSTACK-2648
This addresses bug Cloudstack-2648.
Diffs (updated)
-----
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 8b996d1
patches/systemvm/debian/config/root/deleteIpAlias.sh 865ff3b
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5f99a15
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java a2cceb1
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037
Diff: https://reviews.apache.org/r/11437/diff/
Testing
-------
tested on master.
Thanks,
bharat kumar
Re: Review Request: CLOUDSTACK-2648 [Multiple_IP_Ranges] Reboot or
start/stop router vm deletes the ip alises created on VR in case of
multiple subnets
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11437/#review21309
-----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/11437/#comment44206>
Please ignore this revision of the diff. i Uploaded the wrong one.
- bharat kumar
On June 3, 2013, 10:01 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11437/
> -----------------------------------------------------------
>
> (Updated June 3, 2013, 10:01 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> [Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises created on VR in case of multiple subnets
> https://issues.apache.org/jira/browse/CLOUDSTACK-2648
>
>
> This addresses bug Cloudstack-2648.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 214e292
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java b969be2
>
> Diff: https://reviews.apache.org/r/11437/diff/
>
>
> Testing
> -------
>
> tested on master.
>
>
> Thanks,
>
> bharat kumar
>
>