[GitHub] [pulsar] merlimat opened a new pull request #11922: Improved logic for pausing replicated subscription snapshots when no traffic

[GitBox <gi...@apache.org>]

merlimat opened a new pull request #11922:
URL: https://github.com/apache/pulsar/pull/11922


   ### Motivation
   
   In #10292, we've added logic to pause the creation of new replicated subscription snapshots when there is no traffic. 
   
   Here, I'm changing it to a different approach to avoid a potential issue and to simplify the logic. 
   
   Comparing the last message id, we had to use stop taking a snapshot when there are no connected producer, in order to create a "quiet period" and check if the last message id didn't change. 
   
   What can happen is that if producers disconnect, we might not create the last snapshot (at least until new producers will get connected). 
   
   ### Modifications
   
   Instead of checking producers and last message id, let's make sure that the last snapshot was initiated after the last "data" message was published. With "data" message here meaning any non-marker message.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #11922: Improved logic for pausing replicated subscription snapshots when no traffic

[GitBox <gi...@apache.org>]

merlimat merged pull request #11922:
URL: https://github.com/apache/pulsar/pull/11922


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org