You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/14 08:04:13 UTC
[GitHub] [couchdb] jaydoane commented on issue #2447: Improve replication
stats handling
jaydoane commented on issue #2447: Improve replication stats handling
URL: https://github.com/apache/couchdb/pull/2447#issuecomment-574052959
The code looks great, but I had some comments on the commit text. Sadly, there's apparently no way in github to comment on it directly :\
> Not preserving that statistic meant users could perceive a data loss.
Do you mean users might not notice if a data loss occurred because they wouldn't notice that docs didn't replicate? Or that the incorrect stat was itself might be perceived as data loss?
> These statistics were already log in the checkpoint history
Should be _logged_?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services