You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jordan Ly <jo...@gmail.com> on 2018/04/12 01:05:21 UTC
Review Request 66573: Add initial interval before searching for
preemption slots
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66573/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Stephan Erb.
Repository: aurora
Description
-------
Between failovers, tasks that normally would not require preemption could be in a PENDING state for an extended period of time and become eligible for preemption. Thus, when the scheduler starts, offers could not have been processed yet and the tasks can preempt other tasks needlessly.
Added an initial delay to preemption slot searching on scheduler startup so PENDING tasks have a chance to be scheduled before preempting.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 7618efc2c0cb46e96119accd2c7962ea8ee7a05e
src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 0a16d3c95d3f262686936330ac7d7dc332d759d5
Diff: https://reviews.apache.org/r/66573/diff/1/
Testing
-------
`./gradlew test`
Will deploy on a cluster to ensure preemption does not start for the initial interval.
Thanks,
Jordan Ly
Re: Review Request 66573: Add initial interval before searching for
preemption slots
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66573/#review200974
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On April 12, 2018, 3:05 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66573/
> -----------------------------------------------------------
>
> (Updated April 12, 2018, 3:05 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Between failovers, tasks that normally would not require preemption could be in a PENDING state for an extended period of time and become eligible for preemption. Thus, when the scheduler starts, offers could not have been processed yet and the tasks can preempt other tasks needlessly.
>
> Added an initial delay to preemption slot searching on scheduler startup so PENDING tasks have a chance to be scheduled before preempting.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 7618efc2c0cb46e96119accd2c7962ea8ee7a05e
> src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 0a16d3c95d3f262686936330ac7d7dc332d759d5
>
>
> Diff: https://reviews.apache.org/r/66573/diff/1/
>
>
> Testing
> -------
>
> `./gradlew test`
>
> Will deploy on a cluster to ensure preemption does not start for the initial interval.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 66573: Add initial interval before searching for
preemption slots
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66573/#review200968
-----------------------------------------------------------
Ship it!
Master (cbe99f5) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 12, 2018, 1:05 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66573/
> -----------------------------------------------------------
>
> (Updated April 12, 2018, 1:05 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Between failovers, tasks that normally would not require preemption could be in a PENDING state for an extended period of time and become eligible for preemption. Thus, when the scheduler starts, offers could not have been processed yet and the tasks can preempt other tasks needlessly.
>
> Added an initial delay to preemption slot searching on scheduler startup so PENDING tasks have a chance to be scheduled before preempting.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 7618efc2c0cb46e96119accd2c7962ea8ee7a05e
> src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 0a16d3c95d3f262686936330ac7d7dc332d759d5
>
>
> Diff: https://reviews.apache.org/r/66573/diff/1/
>
>
> Testing
> -------
>
> `./gradlew test`
>
> Will deploy on a cluster to ensure preemption does not start for the initial interval.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 66573: Add initial interval before searching for
preemption slots
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66573/#review200954
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On April 12, 2018, 1:05 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66573/
> -----------------------------------------------------------
>
> (Updated April 12, 2018, 1:05 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Between failovers, tasks that normally would not require preemption could be in a PENDING state for an extended period of time and become eligible for preemption. Thus, when the scheduler starts, offers could not have been processed yet and the tasks can preempt other tasks needlessly.
>
> Added an initial delay to preemption slot searching on scheduler startup so PENDING tasks have a chance to be scheduled before preempting.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 7618efc2c0cb46e96119accd2c7962ea8ee7a05e
> src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 0a16d3c95d3f262686936330ac7d7dc332d759d5
>
>
> Diff: https://reviews.apache.org/r/66573/diff/1/
>
>
> Testing
> -------
>
> `./gradlew test`
>
> Will deploy on a cluster to ensure preemption does not start for the initial interval.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 66573: Add initial interval before searching for
preemption slots
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66573/#review200950
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On April 11, 2018, 6:05 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66573/
> -----------------------------------------------------------
>
> (Updated April 11, 2018, 6:05 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Between failovers, tasks that normally would not require preemption could be in a PENDING state for an extended period of time and become eligible for preemption. Thus, when the scheduler starts, offers could not have been processed yet and the tasks can preempt other tasks needlessly.
>
> Added an initial delay to preemption slot searching on scheduler startup so PENDING tasks have a chance to be scheduled before preempting.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 7618efc2c0cb46e96119accd2c7962ea8ee7a05e
> src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 0a16d3c95d3f262686936330ac7d7dc332d759d5
>
>
> Diff: https://reviews.apache.org/r/66573/diff/1/
>
>
> Testing
> -------
>
> `./gradlew test`
>
> Will deploy on a cluster to ensure preemption does not start for the initial interval.
>
>
> Thanks,
>
> Jordan Ly
>
>