You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stdcxx.apache.org by Liviu Nicoara <li...@roguewave.com> on 2007/09/06 17:54:49 UTC

[PATCH] STDCXX-541

I am attaching a tentative patch for review, in relation with STDCXX-541 
(https://issues.apache.org/jira/browse/STDCXX-541). Testing showed it 
solves the test case failure and adds no extra failures in the stdcxx 
strings test suite. This solves quite a few of related failures in 
strings in downstream products.

ChangeLog:
* rw/_traits.h: added cast to unsigned char






Re: [PATCH] STDCXX-541

Posted by Martin Sebor <se...@roguewave.com>.
Liviu Nicoara wrote:
> I am attaching a tentative patch for review, in relation with STDCXX-541 
> (https://issues.apache.org/jira/browse/STDCXX-541). Testing showed it 
> solves the test case failure and adds no extra failures in the stdcxx 
> strings test suite. This solves quite a few of related failures in 
> strings in downstream products.

The patch looks good to me. Go ahead and commit it whenever you're
ready. Thanks!

> 
> ChangeLog:
> * rw/_traits.h: added cast to unsigned char

Please make sure to follow the expected Change Log format. Here's
an example of a good one :)

http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg00464.html

Martin