You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/09 06:16:34 UTC

[GitHub] [apisix] idbeta opened a new issue #2665: bug: The maximum length of the name when creating a route is 100, but an error will still be prompted at the end

idbeta opened a new issue #2665:
URL: https://github.com/apache/apisix/issues/2665


   - Why do you submit this issue?
   - [ ] Question or discussion
   - [x] Bug
   - [ ] Requirements
   - [ ] Feature or performance improvement
   - [ ] Other
   
   ### Bug
   - Which version of Apache APISIX Dashboard, OS, and Browser?
   APISIX 2.0 + APISIX-dashboard 2.0
   
   The maximum length of the name when creating a route is 100, but input a name of 100 length an error will still be prompted at the end.
   ![image](https://user-images.githubusercontent.com/7396835/98465619-19ebd980-2205-11eb-877b-84b5b930ef4d.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] juzhiyuan commented on issue #2665: chore: The maximum length of the name when creating a route is 100, but an error will still be prompted at the end

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #2665:
URL: https://github.com/apache/apisix/issues/2665#issuecomment-723796053


   Just wait, we should make a decision on this issue, what's the proper mac limit? If 100 is good to go, then we should update the backend. If 50 is enough, then let the frontend to update. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] membphis commented on issue #2665: chore: The maximum length of the name when creating a route is 100, but an error will still be prompted at the end

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2665:
URL: https://github.com/apache/apisix/issues/2665#issuecomment-723794469


   > It seems to fix the logic both in manager-api and APISIX,
   > the name of route has max length 50 in APISIX
   
   we should change the max length to  `100`, same as the dashboard.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] membphis commented on issue #2665: chore: The maximum length of the name when creating a route is 100, but an error will still be prompted at the end

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2665:
URL: https://github.com/apache/apisix/issues/2665#issuecomment-723814233


   > If 100 is good to go, then we should update the backend.
   
   I vote for this. `50` is small.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] gxthrj commented on issue #2665: bug: The maximum length of the name when creating a route is 100, but an error will still be prompted at the end

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #2665:
URL: https://github.com/apache/apisix/issues/2665#issuecomment-723788245


   @spacewander @Firstsawyou do you have time to resolveļ¼Œthe max length of route name is 50 in APISIX by now, it seems to short. and we had better to  keep it the same as dashboard.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] juzhiyuan edited a comment on issue #2665: chore: The maximum length of the name when creating a route is 100, but an error will still be prompted at the end

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #2665:
URL: https://github.com/apache/apisix/issues/2665#issuecomment-723796053


   Just wait, we should make a decision on this issue, what's the proper max limit? If 100 is good to go, then we should update the backend. If 50 is enough, then let the frontend to update. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] membphis closed issue #2665: chore: The maximum length of the name when creating a route is 100, but an error will still be prompted at the end

Posted by GitBox <gi...@apache.org>.
membphis closed issue #2665:
URL: https://github.com/apache/apisix/issues/2665


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org