You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Amy Nordberg (JIRA)" <ji...@apache.org> on 2008/11/10 21:30:37 UTC
[jira] Created: (WW-2863) onchange handler doesn't fire on
doubleselect tag
onchange handler doesn't fire on doubleselect tag
-------------------------------------------------
Key: WW-2863
URL: https://issues.apache.org/struts/browse/WW-2863
Project: Struts 2
Issue Type: Bug
Reporter: Amy Nordberg
doubleselect tag documentation (at http://struts.apache.org/2.0.11.2/docs/doubleselect.html) says onchange is supported. But it doesn't fire (see below).
<s:doubleselect formName="theForm" required="true" requiredposition="left"
key="facilityInstanceName" doubleName="instanceName"
list="facilityInstances" doubleList="instances"
listKey="facilityInstanceName" doubleListKey="instanceName"
listValue="facilityInstanceName" doubleListValue="instanceName"
value="defaultFacility" doubleValue="defaultInstance"
onchange="setFormButtons();/>
See also the comments at http://thefiles.macadamian.com/2008/04/struts-2-doubleselect-detailed-example.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2863) onchange handler doesn't fire on
doubleselect tag
Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nils-Helge Garli resolved WW-2863.
----------------------------------
Resolution: Fixed
I've committed a fix as suggested.
> onchange handler doesn't fire on doubleselect tag
> -------------------------------------------------
>
> Key: WW-2863
> URL: https://issues.apache.org/struts/browse/WW-2863
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.1.6
> Reporter: Amy Nordberg
> Assignee: Nils-Helge Garli
> Fix For: 2.1.7
>
>
> doubleselect tag documentation (at http://struts.apache.org/2.0.11.2/docs/doubleselect.html) says onchange is supported. But it doesn't fire (see below).
> <s:doubleselect formName="theForm" required="true" requiredposition="left"
> key="facilityInstanceName" doubleName="instanceName"
> list="facilityInstances" doubleList="instances"
> listKey="facilityInstanceName" doubleListKey="instanceName"
> listValue="facilityInstanceName" doubleListValue="instanceName"
> value="defaultFacility" doubleValue="defaultInstance"
> onchange="setFormButtons();/>
> See also the comments at http://thefiles.macadamian.com/2008/04/struts-2-doubleselect-detailed-example.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2863) onchange handler doesn't fire on
doubleselect tag
Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46107#action_46107 ]
Nils-Helge Garli commented on WW-2863:
--------------------------------------
I'd say it's pretty useless if it can't be set by the user. I suggest that we append the user setting to the default setting.
> onchange handler doesn't fire on doubleselect tag
> -------------------------------------------------
>
> Key: WW-2863
> URL: https://issues.apache.org/struts/browse/WW-2863
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.1.6
> Reporter: Amy Nordberg
> Fix For: 2.1.7
>
>
> doubleselect tag documentation (at http://struts.apache.org/2.0.11.2/docs/doubleselect.html) says onchange is supported. But it doesn't fire (see below).
> <s:doubleselect formName="theForm" required="true" requiredposition="left"
> key="facilityInstanceName" doubleName="instanceName"
> list="facilityInstances" doubleList="instances"
> listKey="facilityInstanceName" doubleListKey="instanceName"
> listValue="facilityInstanceName" doubleListValue="instanceName"
> value="defaultFacility" doubleValue="defaultInstance"
> onchange="setFormButtons();/>
> See also the comments at http://thefiles.macadamian.com/2008/04/struts-2-doubleselect-detailed-example.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2863) onchange handler doesn't fire on
doubleselect tag
Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes Wannemacher updated WW-2863:
--------------------------------
Flags: [Important] (was: [Important, Patch])
Component/s: Core Actions
Affects Version/s: 2.1.6
Fix Version/s: 2.1.7
> onchange handler doesn't fire on doubleselect tag
> -------------------------------------------------
>
> Key: WW-2863
> URL: https://issues.apache.org/struts/browse/WW-2863
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.1.6
> Reporter: Amy Nordberg
> Fix For: 2.1.7
>
>
> doubleselect tag documentation (at http://struts.apache.org/2.0.11.2/docs/doubleselect.html) says onchange is supported. But it doesn't fire (see below).
> <s:doubleselect formName="theForm" required="true" requiredposition="left"
> key="facilityInstanceName" doubleName="instanceName"
> list="facilityInstances" doubleList="instances"
> listKey="facilityInstanceName" doubleListKey="instanceName"
> listValue="facilityInstanceName" doubleListValue="instanceName"
> value="defaultFacility" doubleValue="defaultInstance"
> onchange="setFormButtons();/>
> See also the comments at http://thefiles.macadamian.com/2008/04/struts-2-doubleselect-detailed-example.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2863) onchange handler doesn't fire on
doubleselect tag
Posted by "Amy Nordberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46108#action_46108 ]
Amy Nordberg commented on WW-2863:
----------------------------------
Hear hear!!
> onchange handler doesn't fire on doubleselect tag
> -------------------------------------------------
>
> Key: WW-2863
> URL: https://issues.apache.org/struts/browse/WW-2863
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.1.6
> Reporter: Amy Nordberg
> Assignee: Nils-Helge Garli
> Fix For: 2.1.7
>
>
> doubleselect tag documentation (at http://struts.apache.org/2.0.11.2/docs/doubleselect.html) says onchange is supported. But it doesn't fire (see below).
> <s:doubleselect formName="theForm" required="true" requiredposition="left"
> key="facilityInstanceName" doubleName="instanceName"
> list="facilityInstances" doubleList="instances"
> listKey="facilityInstanceName" doubleListKey="instanceName"
> listValue="facilityInstanceName" doubleListValue="instanceName"
> value="defaultFacility" doubleValue="defaultInstance"
> onchange="setFormButtons();/>
> See also the comments at http://thefiles.macadamian.com/2008/04/struts-2-doubleselect-detailed-example.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2863) onchange handler doesn't fire on
doubleselect tag
Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45973#action_45973 ]
Wes Wannemacher commented on WW-2863:
-------------------------------------
the onchange parameter is definitely eaten. After looking at freemarker templates for about 30 minutes and not finding anything, I found the culprit in org.apache.struts2.components.DoubleSelect.java. The line 'addParameter("onchange", getParameters().get("id") + "Redirect(this.options.selectedIndex)");' will definitely eat anything you have set. It would probably be better to either fix the docs or store what the user specified and tack that onto what we are setting.
> onchange handler doesn't fire on doubleselect tag
> -------------------------------------------------
>
> Key: WW-2863
> URL: https://issues.apache.org/struts/browse/WW-2863
> Project: Struts 2
> Issue Type: Bug
> Reporter: Amy Nordberg
>
> doubleselect tag documentation (at http://struts.apache.org/2.0.11.2/docs/doubleselect.html) says onchange is supported. But it doesn't fire (see below).
> <s:doubleselect formName="theForm" required="true" requiredposition="left"
> key="facilityInstanceName" doubleName="instanceName"
> list="facilityInstances" doubleList="instances"
> listKey="facilityInstanceName" doubleListKey="instanceName"
> listValue="facilityInstanceName" doubleListValue="instanceName"
> value="defaultFacility" doubleValue="defaultInstance"
> onchange="setFormButtons();/>
> See also the comments at http://thefiles.macadamian.com/2008/04/struts-2-doubleselect-detailed-example.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WW-2863) onchange handler doesn't fire on
doubleselect tag
Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nils-Helge Garli reassigned WW-2863:
------------------------------------
Assignee: Nils-Helge Garli
> onchange handler doesn't fire on doubleselect tag
> -------------------------------------------------
>
> Key: WW-2863
> URL: https://issues.apache.org/struts/browse/WW-2863
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.1.6
> Reporter: Amy Nordberg
> Assignee: Nils-Helge Garli
> Fix For: 2.1.7
>
>
> doubleselect tag documentation (at http://struts.apache.org/2.0.11.2/docs/doubleselect.html) says onchange is supported. But it doesn't fire (see below).
> <s:doubleselect formName="theForm" required="true" requiredposition="left"
> key="facilityInstanceName" doubleName="instanceName"
> list="facilityInstances" doubleList="instances"
> listKey="facilityInstanceName" doubleListKey="instanceName"
> listValue="facilityInstanceName" doubleListValue="instanceName"
> value="defaultFacility" doubleValue="defaultInstance"
> onchange="setFormButtons();/>
> See also the comments at http://thefiles.macadamian.com/2008/04/struts-2-doubleselect-detailed-example.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.