[GitHub] [activemq-artemis] clebertsuconic edited a comment on issue #2762: ARTEMIS-2408 Changing FileDescriptors rule as classRule

[GitBox <gi...@apache.org>]

clebertsuconic edited a comment on issue #2762: ARTEMIS-2408 Changing FileDescriptors rule as classRule
URL: https://github.com/apache/activemq-artemis/pull/2762#issuecomment-513284466
 
 
   @brusdev: I'm a bit concerned about the lsof check, as being dead code.. the day you need it it hasn't been used forever and nobody knows what it does. say you and me retire in 10 years, or we decide to move to another project, people dealing with this codebase will have no clue.
   
   I changed it to show all the opened files in case there is a leak.. you as a developer would be able to figure out by looking at the list.
   
   I also changed the timeout on shutdown. The issue is that once you added the block shutdown the tests were taking a lot of time to process those. with this at 0, I could get back to previous times.
   
   If you could please review this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services