You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 18:43:41 UTC
[GitHub] [airflow] rootcss opened a new pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
rootcss opened a new pull request #11316:
URL: https://github.com/apache/airflow/pull/11316
SSHHook was creating the paramiko client every time execute() method was called. This PR makes change to re-use the previously established connection.
closes: https://github.com/apache/airflow/issues/10874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] HaloKo4 commented on pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
Posted by GitBox <gi...@apache.org>.
HaloKo4 commented on pull request #11316:
URL: https://github.com/apache/airflow/pull/11316#issuecomment-716985425
@rootcss there are failures with `test_pickle_file_transfer_get `of `tests/providers/sftp/operators/test_sftp.py` which uses SSH.
there are other tests that also fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] HaloKo4 commented on pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
Posted by GitBox <gi...@apache.org>.
HaloKo4 commented on pull request #11316:
URL: https://github.com/apache/airflow/pull/11316#issuecomment-776557272
@rootcss did you manage to solve it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11316:
URL: https://github.com/apache/airflow/pull/11316#issuecomment-704589320
[The Build Workflow run](https://github.com/apache/airflow/actions/runs/292186194) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rootcss commented on pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
Posted by GitBox <gi...@apache.org>.
rootcss commented on pull request #11316:
URL: https://github.com/apache/airflow/pull/11316#issuecomment-716989516
@HaloKo4 yes, I looked at the errors. I couldn't find the cause on the first look, will check and fix it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rootcss closed pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
Posted by GitBox <gi...@apache.org>.
rootcss closed pull request #11316:
URL: https://github.com/apache/airflow/pull/11316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11316:
URL: https://github.com/apache/airflow/pull/11316#issuecomment-712009918
Could you rebase please @rootcss - we had some CI failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #11316:
URL: https://github.com/apache/airflow/pull/11316#issuecomment-751239962
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11316:
URL: https://github.com/apache/airflow/pull/11316#issuecomment-751294133
Hey @rootcss - can you please rebase it ? We now released 2.0 so it might make sense to merge this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11316:
URL: https://github.com/apache/airflow/pull/11316#issuecomment-704589031
[The Build Workflow run](https://github.com/apache/airflow/actions/runs/292180024) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11316: Re-use paramiko connection in SSHHook instead of recreating
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11316:
URL: https://github.com/apache/airflow/pull/11316#issuecomment-721446266
Can you please rebase your PR on latest Master since we have applied [Black](https://github.com/apache/airflow/commit/4e8f9cc8d02b29c325b8a5a76b4837671bdf5f68) and [PyUpgrade](https://github.com/apache/airflow/commit/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5) on Master.
It will help if your squash your commits into single commit first so that there are less conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org