You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2006/08/28 23:16:42 UTC

svn commit: r437840 - /directory/branches/shared/0.9.5/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapControlGrammar.java

Author: elecharny
Date: Mon Aug 28 14:16:41 2006
New Revision: 437840

URL: http://svn.apache.org/viewvc?rev=437840&view=rev
Log:
Added a comment to clarify an exception

Modified:
    directory/branches/shared/0.9.5/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapControlGrammar.java

Modified: directory/branches/shared/0.9.5/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapControlGrammar.java
URL: http://svn.apache.org/viewvc/directory/branches/shared/0.9.5/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapControlGrammar.java?rev=437840&r1=437839&r2=437840&view=diff
==============================================================================
--- directory/branches/shared/0.9.5/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapControlGrammar.java (original)
+++ directory/branches/shared/0.9.5/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapControlGrammar.java Mon Aug 28 14:16:41 2006
@@ -181,6 +181,8 @@
                     if ( tlv.getLength().getLength() == 0 )
                     {
                         log.error( "The OID must not be null" );
+                        
+                        // This will generate a PROTOCOL_ERROR
                         throw new DecoderException( "The OID must not be null" );
                     }
                     else
@@ -195,6 +197,7 @@
                             log.error( "The control type " + StringTools.dumpBytes( tlv.getValue().getData() )
                                 + " is not a valid OID : " + de.getMessage() );
 
+                            // This will generate a PROTOCOL_ERROR
                             throw de;
                         }
 
@@ -207,6 +210,7 @@
                             log.error( "The control type " + StringTools.dumpBytes( tlv.getValue().getData() )
                                 + " is invalid : " + lsee.getMessage() );
 
+                            // This will generate a PROTOCOL_ERROR
                             throw new DecoderException( lsee.getMessage() );
                         }
                     }
@@ -267,6 +271,7 @@
                         log.error( "The control criticality flag " + StringTools.dumpBytes( value.getData() )
                             + " is invalid : " + bde.getMessage() + ". It should be 0 or 255" );
 
+                        // This will generate a PROTOCOL_ERROR
                         throw new DecoderException( bde.getMessage() );
                     }