RE: svn commit: r1605159 - in /subversion/branches/svn-auth-x509/subversion: include/svn_error_codes.h libsvn_subr/x509.h libsvn_subr/x509parse.c svn/auth-cmd.c

[Bert Huijben <be...@qqmail.nl>]

> -----Original Message-----
> From: stsp@apache.org [mailto:stsp@apache.org]
> Sent: dinsdag 24 juni 2014 21:13
> To: commits@subversion.apache.org
> Subject: svn commit: r1605159 - in /subversion/branches/svn-auth-
> x509/subversion: include/svn_error_codes.h libsvn_subr/x509.h
> libsvn_subr/x509parse.c svn/auth-cmd.c
> 
> Author: stsp
> Date: Tue Jun 24 19:13:14 2014
> New Revision: 1605159
> 
> URL: http://svn.apache.org/r1605159
> Log:
> On the svn-auth-x509 branch, make the X509 parser return svn-style errors.
> 
> * subversion/include/svn_error_codes.h
>   (SVN_ERR_X509_CATEGORY_START): New error category for the X509
> parser.
>   (SVN_ERR_ASN1_OUT_OF_DATA, SVN_ERR_ASN1_UNEXPECTED_TAG,
>    SVN_ERR_ASN1_INVALID_LENGTH, SVN_ERR_ASN1_LENGTH_MISMATCH,
>    SVN_ERR_ASN1_INVALID_DATA,
> SVN_ERR_X509_FEATURE_UNAVAILABLE,
>    SVN_ERR_X509_CERT_INVALID_PEM,
> SVN_ERR_X509_CERT_INVALID_FORMAT,
>    SVN_ERR_X509_CERT_INVALID_VERSION,
> SVN_ERR_X509_CERT_INVALID_SERIAL,
>    SVN_ERR_X509_CERT_INVALID_ALG,
> SVN_ERR_X509_CERT_INVALID_NAME,
>    SVN_ERR_X509_CERT_INVALID_DATE,
> SVN_ERR_X509_CERT_INVALID_PUBKEY,
>    SVN_ERR_X509_CERT_INVALID_SIGNATURE,
> SVN_ERR_X509_CERT_INVALID_EXTENSIONS,
>    SVN_ERR_X509_CERT_UNKNOWN_VERSION,
> SVN_ERR_X509_CERT_UNKNOWN_SIG_ALG,
>    SVN_ERR_X509_CERT_UNKNOWN_PK_ALG,
> SVN_ERR_X509_CERT_SIG_MISMATCH,
>    SVN_ERR_X509_CERT_VERIFY_FAILED): New error codes. Mapped from
> tropicssl.

[Moving to dev@]

21:25 <@Bert> stsp: Just wondering: do we really need to wrap all of these as separate error codes? (E.g. we don't do
              that for sqlite, which has less error values than this parser)

	Bert