You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/07/29 19:23:14 UTC
[GitHub] [cordova-plugin-statusbar] fquirin opened a new pull request, #235: Android: fix 'darkContentStyles' with new 'WindowInsetsControllerCompat'
fquirin opened a new pull request, #235:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/235
Added 'WindowInsetsControllerCompat.setAppearanceLightStatusBars' to 'setStatusBarStyle' to fix dark content styles
### Platforms affected
- Android
### Motivation and Context
In Android 12 the dark-content style wasn't working anymore due to the deprecated `View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR`.
### Description
I've added the new `WindowInsetsControllerCompat.setAppearanceLightStatusBars` method to make it work again.
### Testing
Built the app with Cordova 11.0.0 and Android Studio and tested on Android 12 emulator, Android 11 device and Android 7 device.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] terreng commented on pull request #235: Android: fix 'darkContentStyles' with new 'WindowInsetsControllerCompat'
Posted by GitBox <gi...@apache.org>.
terreng commented on PR #235:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/235#issuecomment-1220167034
Works for me 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] jcesarmobile closed pull request #235: Android: fix 'darkContentStyles' with new 'WindowInsetsControllerCompat'
Posted by GitBox <gi...@apache.org>.
jcesarmobile closed pull request #235: Android: fix 'darkContentStyles' with new 'WindowInsetsControllerCompat'
URL: https://github.com/apache/cordova-plugin-statusbar/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org