You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/17 10:31:45 UTC
[GitHub] [incubator-yunikorn-core] manirajv06 opened a new pull request #387: [YUNIKORN-1124] Avoid passing empty nodeAttributes in UpdateNode request
manirajv06 opened a new pull request #387:
URL: https://github.com/apache/incubator-yunikorn-core/pull/387
### What is this PR for?
Core initialise nodeAttributes map and set the default partition when shim is not passing nodeAttributes as part of UpdateRequest (for delete, restore & decommissioning actions).
### What type of PR is it?
* [ ] - Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1124
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #387: [YUNIKORN-1124] Avoid passing empty nodeAttributes in UpdateNode request
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #387:
URL: https://github.com/apache/incubator-yunikorn-core/pull/387#issuecomment-1071938379
@manirajv06 can you log jiras as follow up for the issues described under point 2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s closed pull request #387: [YUNIKORN-1124] Avoid passing empty nodeAttributes in UpdateNode request
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #387:
URL: https://github.com/apache/incubator-yunikorn-core/pull/387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #387: [YUNIKORN-1124] Avoid passing empty nodeAttributes in UpdateNode request
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #387:
URL: https://github.com/apache/incubator-yunikorn-core/pull/387#issuecomment-1071938379
@manirajv06 can you log jiras as follow up for the issues described under point 2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #387: [YUNIKORN-1124] Avoid passing empty nodeAttributes in UpdateNode request
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #387:
URL: https://github.com/apache/incubator-yunikorn-core/pull/387#issuecomment-1070769053
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#387](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (420473c) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
- Coverage 69.40% 69.38% -0.03%
==========================================
Files 66 66
Lines 9475 9475
==========================================
- Hits 6576 6574 -2
- Misses 2655 2656 +1
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/events/event\_publisher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2V2ZW50cy9ldmVudF9wdWJsaXNoZXIuZ28=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/387?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/387?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...420473c](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/387?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on pull request #387: [YUNIKORN-1124] Avoid passing empty nodeAttributes in UpdateNode request
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on pull request #387:
URL: https://github.com/apache/incubator-yunikorn-core/pull/387#issuecomment-1070773205
Notes:
1. Leaving "yunikorn.apache.org/nodeType" change as is for now. @craigcondit can comment on this.
2. I think we should handle "Ready" attribute also as any other node attributes. Managing each attribute in a separate place doesn't seem to be clean and organised, may didn't get our attention at times. Yes, it may change during UpdateNode as well but still we should handle it in `initializeAttribute`, `GetAttribute` methods using appropriate locks like how listeners are being handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s closed pull request #387: [YUNIKORN-1124] Avoid passing empty nodeAttributes in UpdateNode request
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #387:
URL: https://github.com/apache/incubator-yunikorn-core/pull/387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org